From: Ingo Molnar <mingo@elte.hu>
To: Andi Kleen <andi@firstfloor.org>
Cc: Harvey Harrison <harvey.harrison@gmail.com>,
"H. Peter Anvin" <hpa@zytor.com>,
LKML <linux-kernel@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH 1/2] x86: add is_f00f_bug helper to fault_32|64.c
Date: Fri, 18 Jan 2008 10:09:45 +0100 [thread overview]
Message-ID: <20080118090945.GD24337@elte.hu> (raw)
In-Reply-To: <p73d4rzbudl.fsf@bingen.suse.de>
* Andi Kleen <andi@firstfloor.org> wrote:
> Harvey Harrison <harvey.harrison@gmail.com> writes:
>
> > Further towards unifying these files, add another helper in same
> > spirit as is_errata93.
>
> The better way to handle this would be to move all these workarounds
> into notifiers that only get registered on the CPUs that actually have
> the bugs.
>
> There is right now no die notifier in the right place for this, but
> you could just add one there. This is no performance critical place.
agreed in principle, but i think it's perhaps a bit more maintainable if
we first aimed for unification, then did such cleanups ontop of the
unified code. Almost everything we do prior unification is double the
work.
Ingo
next prev parent reply other threads:[~2008-01-18 9:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-17 22:54 [PATCH 1/2] x86: add is_f00f_bug helper to fault_32|64.c Harvey Harrison
2008-01-18 5:00 ` Andi Kleen
2008-01-18 9:09 ` Ingo Molnar [this message]
2008-01-18 13:13 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080118090945.GD24337@elte.hu \
--to=mingo@elte.hu \
--cc=andi@firstfloor.org \
--cc=harvey.harrison@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox