From: Andy Whitcroft <apw@shadowen.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Randy Dunlap <rdunlap@xenotime.net>,
Joel Schopp <jschopp@austin.ibm.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] update checkpatch.pl to version 0.13
Date: Fri, 18 Jan 2008 11:37:17 +0000 [thread overview]
Message-ID: <20080118113717.GE18948@shadowen.org> (raw)
In-Reply-To: <20080117111923.c2418586.akpm@linux-foundation.org>
On Thu, Jan 17, 2008 at 11:19:23AM -0800, Andrew Morton wrote:
> On Thu, 17 Jan 2008 16:23:51 -0000 Andy Whitcroft <apw@shadowen.org> wrote:
>
> > This version brings a large number of fixes which have built up over
> > the Christmas period. Mostly these are fixes for false positives, both
> > through improvments to unary checks and possible type detection. It
> > also brings new checks for while location and CVS keywords.
>
> heh. Doctor, heal thyself.
Heh, yeah I was feeling pressure to push out the update and forgot to
check it. Spanner.
I have fixed the three lines which have random tabs on them. Its
something I do in vi which is adding them, one day I will figure out
what the heck it is I do.
-apw
---
clean up some space violations in checkpatch.pl
Seems that something I do in vi leaves lines with multiple tabs on
them lying about. Clean these up before edit things more.
Signed-off-by: Andy Whitcroft <apw@shadowen.org>
---
checkpatch.pl | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/checkpatch.pl b/checkpatch.pl
index 07ba401..a2b4c41 100755
--- a/checkpatch.pl
+++ b/checkpatch.pl
@@ -341,7 +341,7 @@ sub sanitise_line {
my $clean = 'X' x length($1);
$res =~ s@(#\s*(?:error|warning)\s+).*@$1$clean@;
}
-
+
return $res;
}
@@ -947,7 +947,7 @@ sub process {
if ($realcnt) {
# Ignore goto labels.
if ($line =~ /$Ident:\*$/) {
-
+
# Ignore functions being called
} elsif ($line =~ /^.\s*$Ident\s*\(/) {
@@ -1190,7 +1190,7 @@ sub process {
# Ignore those directives where spaces _are_ permitted.
if ($name =~ /^(?:if|for|while|switch|return|volatile|__volatile__|__attribute__|format|__extension__|Copyright|case)$/) {
-
+
# cpp #define statements have non-optional spaces, ie
# if there is a space between the name and the open
# parenthesis it is simply not a parameter group.
--
next prev parent reply other threads:[~2008-01-18 11:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-17 16:23 [PATCH] update checkpatch.pl to version 0.13 Andy Whitcroft
2008-01-17 19:19 ` Andrew Morton
2008-01-18 11:37 ` Andy Whitcroft [this message]
2008-01-18 13:10 ` Benny Halevy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080118113717.GE18948@shadowen.org \
--to=apw@shadowen.org \
--cc=akpm@linux-foundation.org \
--cc=jschopp@austin.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@xenotime.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox