From: Dave Jones <davej@redhat.com>
To: "Pallipadi, Venkatesh" <venkatesh.pallipadi@intel.com>
Cc: Ingo Molnar <mingo@elte.hu>, Yinghai Lu <Yinghai.Lu@Sun.COM>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] X86: fix typo PAT to X86_PAT
Date: Fri, 18 Jan 2008 13:56:35 -0500 [thread overview]
Message-ID: <20080118185635.GD10167@redhat.com> (raw)
In-Reply-To: <924EFEDD5F540B4284297C4DC59F3DEE62B7BA@orsmsx423.amr.corp.intel.com>
On Fri, Jan 18, 2008 at 10:47:05AM -0800, Venki Pallipadi wrote:
> >This exclusion is going to be a real pain in the ass for
> >distro kernels.
> >It's impossible for example to build a kernel that will now support
> >the MTRR-alike registers on the AMD K6/early Cyrix etc and also
> >support PAT.
>
> Actually, this exclusion will not work at all with the current code.
> Infact it should be PAT selects MTRR, for the current code. As
> pat_init() is called during mtrr init as the rules for how to change PAT
> and how to change MTRR are same. Further, MTRR is always required on
> SMP, as we read the MTRR setting from boot CPU and set it on Aps at boot
> time. We should only remove the /proc/mtrr write permissions with
> CONFIG_PAT. We need to deprecate it for a while before that...
> Ingo, can you remove this PAT MTRR exclusion.
The removal of write-permission also needs to be decided at runtime rather than
compile time, or we screw over the "doesn't support PAT" CPUs in distro kernels.
Dave
--
http://www.codemonkey.org.uk
next prev parent reply other threads:[~2008-01-18 18:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-18 3:50 [PATCH] X86: fix typo PAT to X86_PAT Yinghai Lu
2008-01-18 8:10 ` Ingo Molnar
2008-01-18 9:03 ` Yinghai Lu
2008-01-18 12:31 ` Ingo Molnar
2008-01-18 18:24 ` Dave Jones
2008-01-18 18:47 ` Pallipadi, Venkatesh
2008-01-18 18:56 ` Dave Jones [this message]
2008-01-18 21:03 ` Ingo Molnar
2008-01-18 21:02 ` Ingo Molnar
2008-01-19 3:28 ` Dave Jones
2008-01-19 7:56 ` [PATCH] X86: disable X86_PAT really Yinghai Lu
2008-01-19 7:58 ` [PATCH] X86: fix typo PAT to X86_PAT Yinghai Lu
2008-01-22 18:26 ` Pallipadi, Venkatesh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080118185635.GD10167@redhat.com \
--to=davej@redhat.com \
--cc=Yinghai.Lu@Sun.COM \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=venkatesh.pallipadi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).