From: "Frank Ch. Eigler" <fche@redhat.com>
To: Arjan van de Ven <arjan@infradead.org>
Cc: "Frank Ch. Eigler" <fche@redhat.com>,
Arjan van de Ven <arjan@linux.intel.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Ingo Molnar <mingo@elte.hu>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [patch 2/3] Latencytop instrumentations part 1
Date: Fri, 18 Jan 2008 18:11:09 -0500 [thread overview]
Message-ID: <20080118231109.GC27193@redhat.com> (raw)
In-Reply-To: <20080118143334.28ba08ca@laptopd505.fenrus.org>
Hi -
On Fri, Jan 18, 2008 at 02:33:34PM -0800, Arjan van de Ven wrote:
> [...]
> > Can you suggest of some reason why all this instrumentation could
> > not be in the form of standard markers (perhaps conditionally
> > compiled out if necessary)?
>
> sure. Every instrumentation you see is of the nested kind (since the lowest level
> of nesting is already automatic via wchan).
> If markers can provide me the following semantics, I'd be MORE than happy to use markers:
> [...]
> If markers can provide that semantics ... you sold me.
Further to what acme said, markers are semantics-free. Callback
functions that implement your entry & exit semantics can be attached
at run time, at your pleasure. (So can systemtap probes, for that
matter.) The main difference would be that these callback functions
would have manage the per-thread LIFO data structures themselves,
instead of allocating backpointers on the kernel stack. (Bonus marks
for not modifying task_struct. :-)
- FChE
next prev parent reply other threads:[~2008-01-18 23:13 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-18 17:36 [Announce] Development release 0.1 of the LatencyTOP tool Arjan van de Ven
2008-01-18 17:39 ` [patch 1/3] LatencyTOP infrastructure patch Arjan van de Ven
2008-01-20 11:34 ` Helge Deller
2008-01-20 16:47 ` Dmitry Adamushko
2008-01-20 17:18 ` Dmitry Adamushko
2008-01-21 8:06 ` KOSAKI Motohiro
2008-01-21 16:16 ` Arjan van de Ven
2008-01-18 17:40 ` [patch 2/3] Latencytop instrumentations part 1 Arjan van de Ven
2008-01-18 22:26 ` Frank Ch. Eigler
2008-01-18 22:33 ` Arjan van de Ven
2008-01-18 22:47 ` Arnaldo Carvalho de Melo
2008-01-18 23:11 ` Frank Ch. Eigler [this message]
2008-01-18 23:20 ` Arjan van de Ven
2008-01-18 17:42 ` [patch 3/3] LatencyTOP instrumentations part 2 Arjan van de Ven
2008-01-18 18:27 ` [Announce] Development release 0.1 of the LatencyTOP tool Roberto Fichera
2008-01-18 18:35 ` Arjan van de Ven
2008-01-18 18:46 ` Roberto Fichera
2008-01-18 19:02 ` Zan Lynx
2008-01-19 5:07 ` Andi Kleen
2008-01-19 5:16 ` Arjan van de Ven
2008-01-19 5:27 ` Andi Kleen
2008-01-19 5:25 ` Arjan van de Ven
2008-01-19 5:33 ` Andi Kleen
2008-01-19 5:34 ` Arjan van de Ven
2008-01-19 6:08 ` Andi Kleen
2008-01-19 5:37 ` [Announce] Development release 0.1 of the LatencyTOP tool II Andi Kleen
2008-01-21 0:52 ` Development release 0.1 of the LatencyTOP tool KOSAKI Motohiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080118231109.GC27193@redhat.com \
--to=fche@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=arjan@infradead.org \
--cc=arjan@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).