From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755271AbYATSEn (ORCPT ); Sun, 20 Jan 2008 13:04:43 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754209AbYATSEf (ORCPT ); Sun, 20 Jan 2008 13:04:35 -0500 Received: from smtp-out02.alice-dsl.net ([88.44.60.12]:13594 "EHLO smtp-out02.alice-dsl.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754145AbYATSEe (ORCPT ); Sun, 20 Jan 2008 13:04:34 -0500 Date: Sun, 20 Jan 2008 19:04:32 +0100 From: Andi Kleen To: Andi Kleen Cc: mingo@elte.hu, Jeremy Fitzhardinge , tglx@linutronix.de, linux-kernel@vger.kernel.org, venkatesh.pallipadi@intel.com Subject: Re: [PATCH] Fix early_ioremap on x86-64 II Message-ID: <20080120180431.GA7452@basil.nowhere.org> References: <20080120172840.GA24608@basil.nowhere.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080120172840.GA24608@basil.nowhere.org> User-Agent: Mutt/1.5.13 (2006-08-11) X-OriginalArrivalTime: 20 Jan 2008 17:58:19.0125 (UTC) FILETIME=[09FF0250:01C85B8E] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > This patch changes all flushes in init_64.c to be __flush_tlb_all() > and fixes the problem here. Hmm, I see new early crashes with that patch here in some cases unfortunately: PANIC: early exception 06 rip 10:ffffffff8082df2d error 0 cr2 0 Pid: 0, comm: swapper Not tainted 2.6.24-rc8-g7ada4254 #39 Call Trace: [] free_bootmem_core+0x1a/0x6b [] free_bootmem_with_active_regions+0x51/0x67 [] setup_node_bootmem+0x16b/0x1b3 [] acpi_scan_nodes+0x136/0x230 [] numa_initmem_init+0x331/0x459 [] release_console_sem+0x1b4/0x1cd [] release_console_sem+0x1b4/0x1cd [] number+0x10e/0x1f9 [] printk+0x4e/0x56 [] number+0x10e/0x1f9 [] vsnprintf+0x53f/0x583 [] number+0x10e/0x1f9 [] release_console_sem+0x1b4/0x1cd [] vsnprintf+0x53f/0x583 [] early_serial_write+0x22/0x32 Not sure what's going wrong. I think the patch is correct, but there are probably more bugs around triggered by some change. Perhaps it is better to just revert Jeremy's patch (789bad4ca2b604f2f21ae7e3d64b67325ec8f9bb) for now. -Andi