From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758789AbYAUJxp (ORCPT ); Mon, 21 Jan 2008 04:53:45 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1758336AbYAUJxg (ORCPT ); Mon, 21 Jan 2008 04:53:36 -0500 Received: from pentafluge.infradead.org ([213.146.154.40]:56479 "EHLO pentafluge.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758308AbYAUJxf (ORCPT ); Mon, 21 Jan 2008 04:53:35 -0500 Date: Mon, 21 Jan 2008 09:53:31 +0000 From: Christoph Hellwig To: Zhang Rui Cc: lenb@kernel.org, linux-acpi@vger.kernel.org, linux-pm@lists.linux-foundation.org, linux-kernel@vger.kernel.org, sujith.thomas@intel.com Subject: Re: [PATCH 9/10] introduce intel_menlow platform specific driver Message-ID: <20080121095331.GA5333@infradead.org> References: <1200556278.2935.118.camel@acpi-sony.sh.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1200556278.2935.118.camel@acpi-sony.sh.intel.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-SRS-Rewrite: SMTP reverse-path rewritten from by pentafluge.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 17, 2008 at 03:51:17PM +0800, Zhang Rui wrote: > From: Thomas Sujith > > Intel menlow platform specific driver for thermal management. > > Signed-off-by: Thomas Sujith > Signed-off-by: Zhang Rui > --- > drivers/misc/Kconfig | 10 > drivers/misc/Makefile | 1 > drivers/misc/intel_menlow.c | 527 ++++++++++++++++++++++++++++++++++++++++++++ Why is this in drivers/misc? I don't have a thermal.h in mainline, but if this is a new subsystem your adding care to create a directory under drivers/ for it? > +/* > +* intel_menlow.c - Intel menlow Driver for thermal management extension > +* > +* Copyright (C) 2008 Intel Corp > +* Copyright (C) 2008 Sujith Thomas > +* Copyright (C) 2008 Zhang Rui Please add a whitespace before the * so they line up. > +MODULE_AUTHOR("Thomas Sujith"); > +MODULE_AUTHOR("Zhang Rui"); I've never seen a driver with two MODULE_AUTHOR statements before. Does this actually work? What does modinfo -F author say for your module?