From: Jon Masters <jonathan@jonmasters.org>
To: rusty@rustcorp.com.au
Cc: linux-kernel@vger.kernel.org, jcm@jonmasters.org
Subject: [PATCH] add module taint on ndiswrapper
Date: Mon, 21 Jan 2008 20:43:41 +0000 [thread overview]
Message-ID: <20080121204341.GA29679@dallas.jonmasters.org> (raw)
The struct module taints member is supposed to store per-module taint
data. The kernel knows about certain specific external modules that will
taint the kernel, such as ndiswrapper. Use of ndiswrapper possibly
should set the per-module taint in addition to the global kernel
taint flag, unless we're arguing not because wrapper module itself
is not what actually causes the kernel to be tainted as such?
Signed-off-by: Jon Masters <jcm@jonmasters.org>
diff -urp linus_26/kernel/module.c jcm_26/kernel/module.c
--- linus_26/kernel/module.c 2008-01-21 13:16:39.000000000 -0500
+++ jcm_26/kernel/module.c 2008-01-21 15:25:41.000000000 -0500
@@ -1893,7 +1893,7 @@ static struct module *load_module(void _
set_license(mod, get_modinfo(sechdrs, infoindex, "license"));
if (strcmp(mod->name, "ndiswrapper") == 0)
- add_taint(TAINT_PROPRIETARY_MODULE);
+ add_taint_module(mod, TAINT_PROPRIETARY_MODULE);
if (strcmp(mod->name, "driverloader") == 0)
add_taint_module(mod, TAINT_PROPRIETARY_MODULE);
next reply other threads:[~2008-01-21 21:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-21 20:43 Jon Masters [this message]
2008-01-21 23:21 ` [PATCH] add module taint on ndiswrapper Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080121204341.GA29679@dallas.jonmasters.org \
--to=jonathan@jonmasters.org \
--cc=jcm@jonmasters.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox