public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: jeff@garzik.org, akpm@osdl.org, torvalds@osdl.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pata_pdc202xx_old: Fix crashes with ATAPI
Date: Tue, 22 Jan 2008 02:25:10 +0100	[thread overview]
Message-ID: <200801220225.10168.bzolnier@gmail.com> (raw)
In-Reply-To: <20080122000034.3e3f6dbb@lxorguk.ukuu.org.uk>

On Tuesday 22 January 2008, Alan Cox wrote:
> > IDE pdc202xx_old host driver supports ATAPI DMA just fine and in line
> > with the PDC2026x programming guide.
> 
> News to me. It didn't last time I tried it the driver selected PIO.

Hmmm...

commit f3d5b34caae393f13a9486036f98c81cac1595c4
Author: Tobias Oed <tobiasoed@hotmail.com>
Date:   Tue Oct 3 01:14:17 2006 -0700

    [PATCH] Enable cdrom dma access with pdc20265_old

    This patch allows me to use dma with my cd/dvd attached to my on board
    pdc20265 ide controller
...
    Acked-by: Alan Cox <alan@lxorguk.ukuu.org.uk>
    Cc: Bartlomiej Zolnierkiewicz <B.Zolnierkiewicz@elka.pw.edu.pl>
...

Are you by any chance using PDC20263?

[ PDC2026{5,7} should be fine (unless somebody broke it but then git-bisect
  should do the job)... ]

> > > So turn it ATAPI DMA off, these are disk optimised controllers.
> > 
> > This is an acceptable workaround for 2.6.24 but it probably just hides
> > some deeper pata_pdc202xx_old or/and libata problem.
> 
> Hard to be sure. No docs here for the older ones.

I lack the docs for PDC20263...

Bart

  reply	other threads:[~2008-01-22  1:13 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-19 15:51 [PATCH] pata_pdc202xx_old: Fix crashes with ATAPI Alan Cox
2008-01-21 23:13 ` Bartlomiej Zolnierkiewicz
2008-01-22  0:00   ` Alan Cox
2008-01-22  1:25     ` Bartlomiej Zolnierkiewicz [this message]
2008-01-22  1:36       ` Alan Cox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200801220225.10168.bzolnier@gmail.com \
    --to=bzolnier@gmail.com \
    --cc=akpm@osdl.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=jeff@garzik.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox