* [PATCH] add module taint on ndiswrapper
@ 2008-01-21 20:43 Jon Masters
2008-01-21 23:21 ` Rusty Russell
0 siblings, 1 reply; 2+ messages in thread
From: Jon Masters @ 2008-01-21 20:43 UTC (permalink / raw)
To: rusty; +Cc: linux-kernel, jcm
The struct module taints member is supposed to store per-module taint
data. The kernel knows about certain specific external modules that will
taint the kernel, such as ndiswrapper. Use of ndiswrapper possibly
should set the per-module taint in addition to the global kernel
taint flag, unless we're arguing not because wrapper module itself
is not what actually causes the kernel to be tainted as such?
Signed-off-by: Jon Masters <jcm@jonmasters.org>
diff -urp linus_26/kernel/module.c jcm_26/kernel/module.c
--- linus_26/kernel/module.c 2008-01-21 13:16:39.000000000 -0500
+++ jcm_26/kernel/module.c 2008-01-21 15:25:41.000000000 -0500
@@ -1893,7 +1893,7 @@ static struct module *load_module(void _
set_license(mod, get_modinfo(sechdrs, infoindex, "license"));
if (strcmp(mod->name, "ndiswrapper") == 0)
- add_taint(TAINT_PROPRIETARY_MODULE);
+ add_taint_module(mod, TAINT_PROPRIETARY_MODULE);
if (strcmp(mod->name, "driverloader") == 0)
add_taint_module(mod, TAINT_PROPRIETARY_MODULE);
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] add module taint on ndiswrapper
2008-01-21 20:43 [PATCH] add module taint on ndiswrapper Jon Masters
@ 2008-01-21 23:21 ` Rusty Russell
0 siblings, 0 replies; 2+ messages in thread
From: Rusty Russell @ 2008-01-21 23:21 UTC (permalink / raw)
To: Jon Masters; +Cc: linux-kernel, jcm
On Tuesday 22 January 2008 07:43:41 Jon Masters wrote:
> The struct module taints member is supposed to store per-module taint
> data. The kernel knows about certain specific external modules that will
> taint the kernel, such as ndiswrapper. Use of ndiswrapper possibly
> should set the per-module taint in addition to the global kernel
> taint flag, unless we're arguing not because wrapper module itself
> is not what actually causes the kernel to be tainted as such?
>
> Signed-off-by: Jon Masters <jcm@jonmasters.org>
Thanks, applied.
Rusty.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-01-21 23:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-01-21 20:43 [PATCH] add module taint on ndiswrapper Jon Masters
2008-01-21 23:21 ` Rusty Russell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox