Re: [PATCH 09/26] atl1: refactor tx processing

[Jay Cliburn <jacliburn@bellsouth.net>]

On Tue, 22 Jan 2008 04:58:17 -0500
Jeff Garzik <jeff@garzik.org> wrote:

> jacliburn@bellsouth.net wrote:
> > From: Jay Cliburn <jacliburn@bellsouth.net>
> > 
> > Refactor tx processing to use a less convoluted tx packet
> > descriptor and to conform generally with the vendor's current
> > version 1.2.40.2.
> > 
> > Signed-off-by: Jay Cliburn <jacliburn@bellsouth.net>
> > ---
> >  drivers/net/atlx/atl1.c |  265
> > +++++++++++++++++++++++++----------------------
> > drivers/net/atlx/atl1.h |  201 +++++++++++++++++++-----------------
> > 2 files changed, 246 insertions(+), 220 deletions(-)
> 
> for such a huge patch, this description is very tiny.  [describe]
> what is refactored, and why.

Okay, I'll go back and rework the offending descriptions for this and
the other patches in this set.

> what does "less convoluted" mean?

I should have written "simpler," I suppose.

Before:
=======
struct tso_param {
	u32 tsopu;      /* tso_param upper word */
	u32 tsopl;      /* tso_param lower word */
};

struct csum_param {
	u32 csumpu;     /* csum_param upper word */
	u32 csumpl;     /* csum_param lower word */
};

union tpd_descr {
	u64 data;
	struct csum_param csum;
	struct tso_param tso;
};

struct tx_packet_desc {
	__le64 buffer_addr;
	union tpd_descr desc;
};


After:
======
struct tx_packet_desc {
        __le64 buffer_addr;
        __le32 word2;
        __le32 word3;
};