From: Arjan van de Ven <arjan@infradead.org>
To: Nick Piggin <nickpiggin@yahoo.com.au>
Cc: mingo@elte.hu, linux-kernel@vger.kernel.org
Subject: Re: [patch] x86: test case for the RODATA config option
Date: Tue, 22 Jan 2008 21:29:44 -0800 [thread overview]
Message-ID: <20080122212944.34bbf2bd@laptopd505.fenrus.org> (raw)
In-Reply-To: <200801231211.41750.nickpiggin@yahoo.com.au>
On Wed, 23 Jan 2008 12:11:41 +1100
Nick Piggin <nickpiggin@yahoo.com.au> wrote:
> > #ifdef CONFIG_DEBUG_RODATA
> >
> > +const int rodata_test_data = 5;
>
> I guess this should match the 32-bit case, and be zero instead of
> 5?
actually it should have been 5 for both (well any non-zero number)
>
> Can you disallow building as a module, and put this in the test
> code? It could be run from the end of mark_rodata_ro()...
fair; I was developing it as a module (just easier) but yeah it makes more sense as part
of mark_rodata_ro(). I'll do that in the next rev
--
If you want to reach me at my work email, use arjan@linux.intel.com
For development, discussion and tips for power savings,
visit http://www.lesswatts.org
next prev parent reply other threads:[~2008-01-23 5:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-22 22:44 [patch] x86: test case for the RODATA config option Arjan van de Ven
2008-01-23 0:04 ` Ingo Molnar
2008-01-23 1:11 ` Nick Piggin
2008-01-23 5:29 ` Arjan van de Ven [this message]
2008-01-23 9:09 ` Andi Kleen
2008-01-23 14:49 ` Arjan van de Ven
2008-01-23 15:27 ` Andi Kleen
2008-01-23 16:04 ` Arjan van de Ven
2008-01-23 16:54 ` Andi Kleen
2008-01-23 17:49 ` Arjan van de Ven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080122212944.34bbf2bd@laptopd505.fenrus.org \
--to=arjan@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=nickpiggin@yahoo.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox