public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@kernel.org>
To: Wilco Beekhuizen <wilcobeekhuizen@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Missing usb_find_device symbol from usb.c
Date: Wed, 23 Jan 2008 00:08:02 +0200	[thread overview]
Message-ID: <20080122220802.GI26556@does.not.exist> (raw)
In-Reply-To: <6c4c86470801221118x530ee074qedb1da5eac1ca473@mail.gmail.com>

On Tue, Jan 22, 2008 at 08:18:32PM +0100, Wilco Beekhuizen wrote:

> 2.6.24-rc8 (possibly lower rc's too) has usb_find_device removed from
> usb.c. This causes problems when compiling modules that need
> usb_find_device.
> This patch puts the symbol back in place. Unless someone has a good
> reason not to include usb_find_device?
>...

The good reason is that there is no longer any in-kernel user of this 
export, and the kernel does not offer APIs only for external modules.

If there's no in-kernel users that's also a light indication that it 
might not be the correct API to use.

Tell the vendors of the modules using it that they should submit their 
modules for inclusion in the kernel.

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed


  reply	other threads:[~2008-01-22 22:09 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-22 19:18 [PATCH] Missing usb_find_device symbol from usb.c Wilco Beekhuizen
2008-01-22 22:08 ` Adrian Bunk [this message]
2008-01-24  1:37 ` Greg KH
2008-01-24 10:05   ` Wilco Beekhuizen
2008-01-24 11:19     ` Pekka Enberg
2008-01-24 11:49       ` Oliver Neukum
2008-01-24 11:52         ` Pekka Enberg
2008-01-24 12:24           ` Oliver Neukum
2008-01-24 12:34             ` Pekka Enberg
2008-01-24 12:58               ` Oliver Neukum
2008-01-24 13:14                 ` Pekka Enberg
2008-01-24 16:44       ` Greg KH
2008-01-24 17:06         ` Pekka Enberg
2008-01-24 17:20           ` Greg KH
2008-01-24 17:42             ` Pekka Enberg
2008-01-24 18:03               ` Greg KH
2008-01-24 19:25                 ` Pekka J Enberg
2008-01-24 19:57                   ` Oliver Neukum
2008-01-24 20:10                     ` Pekka Enberg
2008-01-24 20:00                 ` Oliver Neukum
2008-01-24 20:26                   ` Pekka Enberg
2008-01-24 20:28                   ` Greg KH
2008-01-25  8:58                     ` Oliver Neukum

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080122220802.GI26556@does.not.exist \
    --to=bunk@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=wilcobeekhuizen@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox