From: Christoph Hellwig <hch@infradead.org>
To: David Chinner <dgc@sgi.com>
Cc: Jonathan Woithe <jwoithe@physics.adelaide.edu.au>,
linux-kernel@vger.kernel.org
Subject: Re: do_remount_sb(RDONLY) race? (was: XFS oops under 2.6.23.9)
Date: Wed, 23 Jan 2008 12:55:04 +0000 [thread overview]
Message-ID: <20080123125504.GC25395@infradead.org> (raw)
In-Reply-To: <20080123053412.GN155259@sgi.com>
On Wed, Jan 23, 2008 at 04:34:12PM +1100, David Chinner wrote:
> I've had suspicions of a race in the remount-ro code in
> do_remount_sb() w.r.t to the fs_may_remount_ro() check. That is, we
> do an unlocked check to see if we can remount readonly and then fail
> to check again once we've locked the superblock out and start the
> remount.
This code is inherently racy, and will be replaced with a proper
per-vfsmount writer count in 2.6.25 as part of the per-mount r/o patches.
prev parent reply other threads:[~2008-01-23 12:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-23 4:30 XFS oops under 2.6.23.9 Jonathan Woithe
2008-01-23 5:34 ` do_remount_sb(RDONLY) race? (was: XFS oops under 2.6.23.9) David Chinner
2008-01-23 5:54 ` Jonathan Woithe
2008-01-23 6:11 ` David Chinner
2008-01-23 12:55 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080123125504.GC25395@infradead.org \
--to=hch@infradead.org \
--cc=dgc@sgi.com \
--cc=jwoithe@physics.adelaide.edu.au \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox