From: Andi Kleen <andi@firstfloor.org>
To: Arjan van de Ven <arjan@infradead.org>
Cc: mingo@elte.hu, linux-kernel@vger.kernel.org
Subject: Re: [patch] x86: test case for the RODATA config option
Date: Wed, 23 Jan 2008 16:27:28 +0100 [thread overview]
Message-ID: <200801231627.28715.andi@firstfloor.org> (raw)
In-Reply-To: <20080123064905.5d05509a@laptopd505.fenrus.org>
> What it does is check if the rodata marking was succesful.
The only difference I see is that you check that the TLB flush works,
but for that it looks awfully incomplete. In particular if you really
wanted to test the TLB you would need to do the access test on
all online CPUs. Otherwise you have no guarantee the TLBs are
actually changed everywhere (assuming that was broken)
Other than it is identical [modulo the kernel mapping bit on 64bit]-- you just
toggle a different bit in the PTE, but c_p_a() does not actually care which
bits you toggle.
>> Testing the kernel mapping might be a good idea, but I would
>> suggest adding it to pageattr-test.c
>where we move the actual test function...
What I meant using the more extensive test in pageattr-test.c
to test a few changes in the 64bit kernel mapping too, not moving your
code. I don't think moving your code makes sense. Sorry for being unclear.
-Andi
next prev parent reply other threads:[~2008-01-23 15:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-22 22:44 [patch] x86: test case for the RODATA config option Arjan van de Ven
2008-01-23 0:04 ` Ingo Molnar
2008-01-23 1:11 ` Nick Piggin
2008-01-23 5:29 ` Arjan van de Ven
2008-01-23 9:09 ` Andi Kleen
2008-01-23 14:49 ` Arjan van de Ven
2008-01-23 15:27 ` Andi Kleen [this message]
2008-01-23 16:04 ` Arjan van de Ven
2008-01-23 16:54 ` Andi Kleen
2008-01-23 17:49 ` Arjan van de Ven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200801231627.28715.andi@firstfloor.org \
--to=andi@firstfloor.org \
--cc=arjan@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox