From: "Ville Syrjälä" <syrjala@sci.fi>
To: David Fries <david@fries.net>
Cc: linux-kernel@vger.kernel.org, Evgeniy Polyakov <johnpol@2ka.mipt.ru>
Subject: Re: [PATCH] W1: w1_therm.c standardize units to millidegrees C
Date: Thu, 24 Jan 2008 14:39:09 +0200 [thread overview]
Message-ID: <20080124123909.GY30987@sci.fi> (raw)
In-Reply-To: <20080124020330.GA19155@spacedout.fries.net>
On Wed, Jan 23, 2008 at 08:03:30PM -0600, David Fries wrote:
> Here is the patch to standardize the temperature units to millidegrees
> C for the two sensor conversion routines. Previously the routines
> were,
>
> w1_DS18B20_convert_temp degrees C
> w1_DS18S20_convert_temp millidegrees C
>
> Unfortunately this will break any program using the ds18b20 value as
> it will now be 1000 times bigger. Fortunately there can't be that
> many users out there, or some of these bugs will have been fixed by
> now, such as the negative C error (see previous patch) that makes me
> think the ds18b20 is the better choice to change because of the
> current bugs.
Why isn't w1_therm presented as a hwmon device?
--
Ville Syrjälä
syrjala@sci.fi
http://www.sci.fi/~syrjala/
next prev parent reply other threads:[~2008-01-24 12:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-24 2:03 [PATCH] W1: w1_therm.c standardize units to millidegrees C David Fries
2008-01-24 12:39 ` Ville Syrjälä [this message]
2008-01-24 14:53 ` Evgeniy Polyakov
2008-01-25 1:49 ` David Fries
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080124123909.GY30987@sci.fi \
--to=syrjala@sci.fi \
--cc=david@fries.net \
--cc=johnpol@2ka.mipt.ru \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox