From: Greg KH <greg@kroah.com>
To: Pekka Enberg <penberg@cs.helsinki.fi>
Cc: Wilco Beekhuizen <wilcobeekhuizen@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Missing usb_find_device symbol from usb.c
Date: Thu, 24 Jan 2008 10:03:13 -0800 [thread overview]
Message-ID: <20080124180313.GA16006@kroah.com> (raw)
In-Reply-To: <84144f020801240942y1c75c82geddc250b7e7814ac@mail.gmail.com>
On Thu, Jan 24, 2008 at 07:42:20PM +0200, Pekka Enberg wrote:
> Hi Greg,
>
> On Jan 24, 2008 7:20 PM, Greg KH <greg@kroah.com> wrote:
> > > So it's not a simple code change at all.
> >
> > Just create a root directory for every device that is seen in the
> > probe() function. That should be pretty simple to do.
>
> Yeah, that would work but why do we want to mount all devices under
> the same mount point? If you move device discovery to ->probe() it's
> simple to have per-device mount points by overriding ->get_sb() to
> check for USB_DEVICE_MAJOR and look up the actual device, no?
> Otherwise you have to deal with device plug/unplug at filesystem
> level...
Yes, you could do that (per device mount), but it might be confusing for
users to have to control things that way.
And the unplug issue at a filesystem level should be pretty trivial to
handle, we do it all the time in /proc and /sys and other virtual
filesystems (usbfs) with no problems.
thanks,
greg k-h
next prev parent reply other threads:[~2008-01-24 18:23 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-22 19:18 [PATCH] Missing usb_find_device symbol from usb.c Wilco Beekhuizen
2008-01-22 22:08 ` Adrian Bunk
2008-01-24 1:37 ` Greg KH
2008-01-24 10:05 ` Wilco Beekhuizen
2008-01-24 11:19 ` Pekka Enberg
2008-01-24 11:49 ` Oliver Neukum
2008-01-24 11:52 ` Pekka Enberg
2008-01-24 12:24 ` Oliver Neukum
2008-01-24 12:34 ` Pekka Enberg
2008-01-24 12:58 ` Oliver Neukum
2008-01-24 13:14 ` Pekka Enberg
2008-01-24 16:44 ` Greg KH
2008-01-24 17:06 ` Pekka Enberg
2008-01-24 17:20 ` Greg KH
2008-01-24 17:42 ` Pekka Enberg
2008-01-24 18:03 ` Greg KH [this message]
2008-01-24 19:25 ` Pekka J Enberg
2008-01-24 19:57 ` Oliver Neukum
2008-01-24 20:10 ` Pekka Enberg
2008-01-24 20:00 ` Oliver Neukum
2008-01-24 20:26 ` Pekka Enberg
2008-01-24 20:28 ` Greg KH
2008-01-25 8:58 ` Oliver Neukum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080124180313.GA16006@kroah.com \
--to=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=penberg@cs.helsinki.fi \
--cc=wilcobeekhuizen@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox