Re: [patch 07/26] Add INIT_ARRAY() to kernel.h (updated)

Mathieu Desnoyers
2008-01-24T21:29:33Z

* Jan Engelhardt (jengelh@computergmbh.de) wrote:
>
> On Jan 24 2008 15:54, Mathieu Desnoyers wrote:
> >
> >Add initialization of an array, which needs brackets that would pollute kernel
> >code, to kernel.h. It is used to declare arguments passed as function parameters
> >such as:
> >text_poke(addr, INIT_ARRAY(unsigned char, 0xf0, len), len);
> >
> >Changelog :
> >- [len] -> []
> >- Remove whitespaces.
> >- Fixed Jan's suggestion which was not checkpatch.pl-safe.
>
> diff -dpru /dev/null <(echo ' #define INIT_ARRAY(type, val, len) ((type[]){[0 ... (len)-1] = (val)}) ') | scripts/checkpatch.pl -
> ERROR: Missing Signed-off-by: line(s)
> total: 1 errors, 0 warnings, 2 lines checked
>
> Where did checkpatch play unfair again on your side? :)
>

Hrm, I don't know why checkpatch does not notice the problem when
invoked with your command, but creating a patch with your change results
in :

compudj@dijkstra:~/git/morestable/linux-2.6-lttng.mm$ scripts/checkpatch.pl patches/test.patch
ERROR: need a space before the open brace '{'
#27: FILE: include/linux/kernel.h:426:
+#define INIT_ARRAY(type, val, len) ((type[]){[0 ... (len)-1] = (val)})

total: 1 errors, 0 warnings, 6 lines checked

Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

but I guess we are deep down in nitpicking land ;)

Cheers,

Mathieu