From: Willy Tarreau <w@1wt.eu>
To: Eric Sandeen <sandeen@redhat.com>
Cc: dann frazier <dannf@dannf.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] 2.4: fix memory corruption from misinterpreted bad_inode_ops return values
Date: Fri, 25 Jan 2008 05:53:21 +0100 [thread overview]
Message-ID: <20080125045320.GA24179@1wt.eu> (raw)
In-Reply-To: <479915AA.9020604@redhat.com>
On Thu, Jan 24, 2008 at 04:48:10PM -0600, Eric Sandeen wrote:
> dann frazier wrote:
>
> > Thanks Eric. Sounds like my comment about exercising these code paths
> > wasn't too clear - the comments with your patch do make the issue
> > clear, and this program demonstrates the void cast promotion issue
> > well. I'm just not sure of a good way to demonstrate that my backport
> > of this patch doesn't break anything for 2.4.
>
> Ugh, no, that was my fault, I blindly copied & pasted something from a
> bug which I thought was a testcase, but isn't. Sorry!
>
> I originally saw this problem on an fsfuzzed filesystem; I don't think I
> still have that image around, though.
OK, that doesn't matter that much. At least the patch makes sense and
your example shows why original code is wrong, so I will merge it. If
anybody had a problem with it, the code would be easily bisectable
(there are so few patches in 2.4) and it's easy to revert it.
Thanks to you both, Eric and Dann !
Willy
prev parent reply other threads:[~2008-01-25 5:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-24 6:12 [PATCH] 2.4: fix memory corruption from misinterpreted bad_inode_ops return values dann frazier
2008-01-24 19:56 ` Willy Tarreau
2008-01-24 21:06 ` Eric Sandeen
2008-01-24 22:39 ` dann frazier
2008-01-24 22:48 ` Eric Sandeen
2008-01-25 4:53 ` Willy Tarreau [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080125045320.GA24179@1wt.eu \
--to=w@1wt.eu \
--cc=dannf@dannf.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox