From: Ingo Molnar <mingo@elte.hu>
To: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: "Huang, Ying" <ying.huang@intel.com>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>, Andi Kleen <ak@suse.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/6] x86: fix some bugs about EFI runtime code mapping
Date: Fri, 25 Jan 2008 10:19:23 +0100 [thread overview]
Message-ID: <20080125091923.GE23708@elte.hu> (raw)
In-Reply-To: <4799914C.5060709@goop.org>
* Jeremy Fitzhardinge <jeremy@goop.org> wrote:
>> +#if defined(CONFIG_X86_64) || defined(CONFIG_X86_PAE)
>> +static void __init runtime_code_page_mkexec(void)
>> +{
>> + efi_memory_desc_t *md;
>> + unsigned long end;
>> + void *p;
>> +
>> + if (!(__supported_pte_mask & _PAGE_NX))
>> + return;
>>
>
> On 32-bit non-PAE, _PAGE_NX == 0, so this if() statement should be
> sufficient to disable the whole function at compile time without
> needing the outer #if defined wrapper.
good point. The patch fixes bugs and the consolidation it does is very
nice so i've applied it already, but we could indeed further consolidate
it and make it a nice #ifdef-less function. Could one of you send an
add-on patch for this?
Ingo
next prev parent reply other threads:[~2008-01-25 9:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-25 5:55 [PATCH 4/6] x86: fix some bugs about EFI runtime code mapping Huang, Ying
2008-01-25 7:35 ` Jeremy Fitzhardinge
2008-01-25 9:19 ` Ingo Molnar [this message]
2008-01-25 9:30 ` Huang, Ying
2008-01-25 9:16 ` Ingo Molnar
2008-01-25 9:26 ` Huang, Ying
2008-01-25 9:48 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080125091923.GE23708@elte.hu \
--to=mingo@elte.hu \
--cc=ak@suse.de \
--cc=hpa@zytor.com \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox