public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: "Huang, Ying" <ying.huang@intel.com>
Cc: Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
	Thomas Gleixner <tglx@linutronix.de>, Andi Kleen <ak@suse.de>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 6/6] x86: fixes some bugs about EFI memory map handling
Date: Fri, 25 Jan 2008 10:31:31 +0100	[thread overview]
Message-ID: <20080125093131.GG23708@elte.hu> (raw)
In-Reply-To: <1201240507.15972.48.camel@caritas-dev.intel.com>


* Huang, Ying <ying.huang@intel.com> wrote:

> This patch fixes some bugs of EFI memory handing code.
> 
> - On x86_64, it is possible that EFI memory map can not be mapped via
>   identity map, so efi_map_memmap is removed, just use early_ioremap.
> 
> - On i386, the EFI memory map mapping take effect cross paging_init,
>   so it is not necessary to use efi_map_memmap.
> 
> - EFI memory map is unmapped in efi_enter_virtual_mode to avoid
>   early_ioremap leak.

thanks, applied.

btw., it would be nice to consolidate this some more. Why is there a 
separate efi_ioremap(), which is mapped to ioremap() on 32-bit, and 
which is mapped to a fixmap based special mapper on 64-bit?

To me it appears this wants to be ioremap() on both 64-bit and 32-bit, 
and we could remove efi_ioremap() altogether. Hm?

	Ingo

  reply	other threads:[~2008-01-25  9:32 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-25  5:55 [PATCH 6/6] x86: fixes some bugs about EFI memory map handling Huang, Ying
2008-01-25  9:31 ` Ingo Molnar [this message]
2008-01-25  9:40   ` Huang, Ying
2008-01-25  9:50     ` Ingo Molnar
2008-01-25 13:58       ` huang ying

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080125093131.GG23708@elte.hu \
    --to=mingo@elte.hu \
    --cc=ak@suse.de \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=ying.huang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox