From: Ingo Molnar <mingo@elte.hu>
To: Minoru Usui <usui@mxm.nes.nec.co.jp>
Cc: linux-kernel@vger.kernel.org, magnus.damm@gmail.com
Subject: Re: [PATCH] Fix NUMA emulation for x86_64
Date: Fri, 25 Jan 2008 11:41:07 +0100 [thread overview]
Message-ID: <20080125104107.GS23708@elte.hu> (raw)
In-Reply-To: <20080125.171613.41631926.usui@mxm.nes.nec.co.jp>
* Minoru Usui <usui@mxm.nes.nec.co.jp> wrote:
> I found a small bug of NUMA emulation code for x86_64.
> (CONFIG_NUMA_EMU) If machine is non-NUMA, find_node_by_addr() should
> return NUMA_NO_NODE, but current implementation code returns existent
> maximum NUMA node number + 1. This is not existent NUMA node number.
>
> However, this behaviour does not affect NUMA emulation fortunately,
> because acpi_fake_nodes() that is caller of find_node_by_addr() gets
> pxm (proximity domain) by node_to_pxm() from non-existent NUMA node
> number that was returned by find_node_by_addr(). node_to_pxm() returns
> PXM_INVAL that means illegal or non-existent NUMA node number.
thanks, i have applied your fix to x86.git.
It seems this does not need to be backported to v2.6.24.1 because
node_to_pxm() masked the bad effects of this bug, right?
Ingo
next prev parent reply other threads:[~2008-01-25 10:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-25 8:16 [PATCH] Fix NUMA emulation for x86_64 Minoru Usui
2008-01-25 10:41 ` Ingo Molnar [this message]
2008-01-30 2:59 ` Minoru Usui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080125104107.GS23708@elte.hu \
--to=mingo@elte.hu \
--cc=linux-kernel@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=usui@mxm.nes.nec.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox