From: Rusty Russell <rusty@rustcorp.com.au>
To: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Valdis.Kletnieks@vt.edu, "Frank Ch. Eigler" <fche@redhat.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Christoph Hellwig <hch@infradead.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Jon Masters <jcm@redhat.com>
Subject: Re: [PATCH] Linux Kernel Markers Support for Proprierary Modules
Date: Fri, 25 Jan 2008 12:27:22 +1100 [thread overview]
Message-ID: <200801251227.22958.rusty@rustcorp.com.au> (raw)
In-Reply-To: <20080124124703.GB32559@Krystal>
On Thursday 24 January 2008 23:47:04 Mathieu Desnoyers wrote:
> There seems to be good arguments for markers to support proprierary
> modules.
My attitude to this is simple: who cares about proprietary modules?
The current test is wrong, it should be checking for forced module loads
(which may not have marker information and may well crash the kernel). Of
course, all forced module loads can crash the kernel, but this is pretty
certain and it's simply to avoid.
We should just flat-out refuse to load a module with a module section too
small. That will cover the majority of this case anyway (*and* the
non-kallsysms case), and then we can remove this test altogether.
Cheers,
Rusty.
next prev parent reply other threads:[~2008-01-25 1:29 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-22 19:13 CONFIG_MARKERS Jon Masters
2008-01-23 3:00 ` CONFIG_MARKERS Frank Ch. Eigler
2008-01-23 3:10 ` CONFIG_MARKERS Mathieu Desnoyers
2008-01-23 4:17 ` CONFIG_MARKERS Jon Masters
2008-01-23 13:14 ` CONFIG_MARKERS Frank Ch. Eigler
2008-01-23 14:48 ` CONFIG_MARKERS Mathieu Desnoyers
2008-01-23 15:01 ` CONFIG_MARKERS Mathieu Desnoyers
2008-01-23 16:33 ` CONFIG_MARKERS Jon Masters
2008-01-23 17:11 ` CONFIG_MARKERS Mathieu Desnoyers
2008-01-24 5:25 ` CONFIG_MARKERS Valdis.Kletnieks
2008-01-24 6:19 ` CONFIG_MARKERS Jon Masters
2008-01-24 12:47 ` [PATCH] Linux Kernel Markers Support for Proprierary Modules Mathieu Desnoyers
2008-01-24 18:27 ` Valdis.Kletnieks
2008-01-24 20:35 ` Jon Masters
2008-01-25 1:27 ` Rusty Russell [this message]
2008-01-25 7:56 ` Jan Engelhardt
2008-01-25 8:03 ` Valdis.Kletnieks
2008-01-25 16:32 ` Alan Cox
2008-01-25 15:31 ` Jon Masters
2008-01-25 16:01 ` Jan Engelhardt
2008-01-26 3:27 ` Rusty Russell
2008-01-26 4:21 ` Jon Masters
2008-01-27 10:48 ` Jan Engelhardt
-- strict thread matches above, loose matches on Subject: below --
2008-02-02 19:51 Mathieu Desnoyers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200801251227.22958.rusty@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=Valdis.Kletnieks@vt.edu \
--cc=akpm@linux-foundation.org \
--cc=fche@redhat.com \
--cc=hch@infradead.org \
--cc=jcm@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@polymtl.ca \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox