From: Len Brown <lenb@kernel.org>
To: Wim Van Sebroeck <wim@iguana.be>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: DMI: create dmi_get_slot()
Date: Fri, 25 Jan 2008 15:19:09 -0500 [thread overview]
Message-ID: <200801251519.09818.lenb@kernel.org> (raw)
In-Reply-To: <20080125201357.GA3234@infomag.infomag.iguana.be>
On Friday 25 January 2008 15:13, Wim Van Sebroeck wrote:
> Hi Len,
>
> I saw you added the dmi_get_slot function recently.
> If I look in drivers/firmware/dmi_scan.c however I now see:
>
> ...
>
> /**
> * dmi_get_system_info - return DMI data value
> * @field: data index (see enum dmi_field)
> *
> * Returns one DMI data value, can be used to perform
> * complex DMI data checks.
> */
> const char *dmi_get_system_info(int field)
> {
> return dmi_ident[field];
> }
> EXPORT_SYMBOL(dmi_get_system_info);
>
> ...
>
> /**
> * dmi_get_slot - return dmi_ident[slot]
> * @slot: index into dmi_ident[]
> */
> char *dmi_get_slot(int slot)
> {
> return(dmi_ident[slot]);
> }
>
> Didn't we duplicate code here?
Yep, thanks for noticing, i'll delete the duplicate.
-Len
prev parent reply other threads:[~2008-01-25 20:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-25 20:13 DMI: create dmi_get_slot() Wim Van Sebroeck
2008-01-25 20:19 ` Len Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200801251519.09818.lenb@kernel.org \
--to=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox