Re: [PATCH 183/196] driver core: fix build with SYSFS=n

Greg KH
2008-01-25T23:16:45Z

On Fri, Jan 25, 2008 at 11:57:23PM +0100, Ingo Molnar wrote:
>
> * Greg KH <gregkh@suse.de> wrote:
>
> > > Changes like this (and it now leaked into Linus' tree as well) kill
> > > bisectability.
> >
> > The odds that a "normal" person has sysfs turned off and modules
> > enabled, trying to bisect things, is pretty slim :)
>
> that "slim" combination is what i use for about 25% of all my bisections
> - i build, boot and stress-test randconfig configs.
>
> If i find a problem with a given .config, i do _not_ go around and
> change the .config to make a bisection point work. (and the automated
> bisection scripts definitely wont do it either.)
>
> so what is a 'weird config' to you is a real testing barrier for others.
> And crap like that quickly mounts up. Having a buildable and bootable
> kernel at every bisection point is a _must_.
>
> Please! :-)

Yes, I do agree that this is important, I'll work to not let this happen
again. Especially now that I have your build scripts, I'm working on
setting up something like that myself here.

thanks,

greg k-h