Re: [PATCH 076/196] ecryptfs: remove version_str file from sysfs

Greg KH
2008-01-25T17:55:57Z

On Fri, Jan 25, 2008 at 03:25:22AM -0500, Jeff Garzik wrote:
> Greg Kroah-Hartman wrote:
>> This file violates the one-value-per-file sysfs rule.
>> If you all want it added back, please do something like a per-feature
>> file to show what is present and what isn't.
>> Cc: Kay Sievers <kay.sievers@vrfy.org>
>> Cc: Mike Halcrow <mhalcrow@us.ibm.com>
>> Cc: Phillip Hellewell <phillip@hellewell.homeip.net>
>> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
>> ---
>> fs/ecryptfs/main.c | 43 -------------------------------------------
>> 1 files changed, 0 insertions(+), 43 deletions(-)
>
> It's not really good policy to rip out ABIs found in release kernels like
> this, even if the motivation is sound.

Normally I would agree, but this file is just so bad, it's not even
funny. I could not find any userspace tools or documentation that used
it, and the ecryptfs developers never responded to any of my emails
concerning it.

The information is still present, just in a different file, so no
functionality is lost here.

> IMO "don't break ABIs" rule is far more important than a one-value-per-file
> sysfs rule.

Just another example of why people need to document this kind of thing
in Documentation/ABI/ which prevents such atrocities from ever being
created in the first place...

thanks,

greg k-h