Re: [PATCH 183/196] driver core: fix build with SYSFS=n

Andrew Morton
2008-01-25T22:34:12Z

> On Fri, 25 Jan 2008 23:25:30 +0100 Ingo Molnar <mingo@elte.hu> wrote:
>
> * Greg Kroah-Hartman <gregkh@suse.de> wrote:
>
> > From: Randy Dunlap <randy.dunlap@oracle.com>
> >
> > When SYSFS=n and MODULES=y, build ends with:
> >
> > linux-2.6.24-rc6-mm1/drivers/base/module.c: In function 'module_add_driver':
> > linux-2.6.24-rc6-mm1/drivers/base/module.c:49: error: 'module_kset' undeclared (first use in this function)
> > make[3]: *** [drivers/base/module.o] Error 1
>
> _PLEASE_ fold such fixes into the patch that introduces the build bugs,
> prior sending your git trees upstream! (just like Andrew does it with
> all patches that come via -mm)
>
> Changes like this (and it now leaked into Linus' tree as well) kill
> bisectability.
>

Absolutely - this is important. After several hours mucking about I just
gave up trying to bisect a 2.6.24-rc1 regression due to hitting 100% build
errors and runtime oopses during the bisection. Mainly from networking in
that case.