Re: [PATCH 076/196] ecryptfs: remove version_str file from sysfs

Jeff Garzik
2008-01-25T08:46:18Z

Greg Kroah-Hartman wrote:
> This file violates the one-value-per-file sysfs rule.
>
> If you all want it added back, please do something like a per-feature
> file to show what is present and what isn't.
>
> Cc: Kay Sievers <kay.sievers@vrfy.org>
> Cc: Mike Halcrow <mhalcrow@us.ibm.com>
> Cc: Phillip Hellewell <phillip@hellewell.homeip.net>
> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
> ---
> fs/ecryptfs/main.c | 43 -------------------------------------------
> 1 files changed, 0 insertions(+), 43 deletions(-)

It's not really good policy to rip out ABIs found in release kernels
like this, even if the motivation is sound.

IMO "don't break ABIs" rule is far more important than a
one-value-per-file sysfs rule.

Jeff