Re: [GIT PATCH] driver core patches against 2.6.24

Greg KH
2008-01-25T19:18:55Z

On Fri, Jan 25, 2008 at 11:11:48AM -0800, Linus Torvalds wrote:
>
>
> On Fri, 25 Jan 2008, Greg KH wrote:
> >
> > That's really wierd, I don't see that at all here just running with your
> > 2.6.24 + my git tree and lots of USB drivers built into the kernel also
> > (like ehci_hcd).
>
> But do you use an initrd that tries to load the same driver too?
>
> I'm too lazy to want to do my own initrd. I just use the prepackaged ones
> and rely on the fact that my private kernel will refuse to load modules
> that aren't meant for it anyway.

No, I don't use any initrd at all.

You should just get a message saying that the version magic doesn't
match, so the initrd modules will not load. That's what happens to me
when I try to force old modules to load.

> > $ cat /proc/sys/kernel/tainted
> > 0
>
> Mine says "2".
>
> > $ uname -r
> > 2.6.24-ge374a2bf-dirty
> >
> > Strange, I thought that the uname id would show the git version that you
> > were running, but that doesn't show a valid id. But that's probably a
> > different issue in the build system somewhere...
>
> That *is* the git version you're running: e374a2bf.
>
> The "-g" is for "git" and the "-dirty" is because you have some
> non-checked-in changes in addition.
>
> I works for me:
>
> [torvalds@hp linux]$ git show --abbrev-commit -s --pretty=oneline e374a2bf
> e374a2b... Kobject: fix coding style issues in kobject c files
>
> so that looks like a valid version..

Ah taking the "g" off the search works, didn't realize that.

And I didn't have any unchecked in files, 'git status' shows no modified
files, but other stuff in the main directory, like patches that
shouldn't matter, but perhaps they do.
But oh well, I'm still building your tree now to try to reproduce
this...

thanks,

greg k-h