Re: [PATCH 085/196] kset: convert s390 ipl.c to use kset_create

Greg KH
2008-01-25T17:51:22Z

On Fri, Jan 25, 2008 at 01:20:53PM +0100, Heiko Carstens wrote:
> On Thu, Jan 24, 2008 at 11:31:54PM -0800, Greg Kroah-Hartman wrote:
> > Dynamically create the kset instead of declaring it statically.
> > This makes the kobject attributes now work properly that I broke in the
> > previous patch.
>
> Could you please merge this and the previous patch before it goes
> upstream? Having an intermediate state where things are broken
> will cause pain and additional work in case of bisecting.

It will not cause a build error (see the previous patch for details.)
The sysfs files will not properly show the correct data, that is all.

The odds that you will hit this in a 'git bisect' is VERY low, and the
previous patch states that the files are now broken, so there should not
be any confusion regarding any user that might run across this.

thanks,

greg k-h