From: Steven Rostedt <rostedt@goodmis.org>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Ingo Molnar <mingo@elte.hu>,
Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Christoph Hellwig <hch@infradead.org>,
Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>,
Gregory Haskins <ghaskins@novell.com>,
Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
Thomas Gleixner <tglx@linutronix.de>,
Tim Bird <tim.bird@am.sony.com>, Sam Ravnborg <sam@ravnborg.org>,
"Frank Ch. Eigler" <fche@redhat.com>,
Jan Kiszka <jan.kiszka@siemens.com>,
John Stultz <johnstul@us.ibm.com>,
Arjan van de Ven <arjan@infradead.org>,
Pavel Machek <pavel@ucw.cz>, Steven Rostedt <srostedt@redhat.com>
Subject: [PATCH 16/23 -v6] trace generic call to schedule switch
Date: Fri, 25 Jan 2008 23:22:08 -0500 [thread overview]
Message-ID: <20080126042803.686515731@goodmis.org> (raw)
In-Reply-To: 20080126042152.526086719@goodmis.org
[-- Attachment #1: trace-sched-hooks.patch --]
[-- Type: text/plain, Size: 5068 bytes --]
This patch adds hooks into the schedule switch tracing to
allow other latency traces to hook into the schedule switches.
Signed-off-by: Steven Rostedt <srostedt@redhat.com>
---
lib/tracing/trace_sched_switch.c | 123 +++++++++++++++++++++++++++++++++------
lib/tracing/tracer.h | 14 ++++
2 files changed, 119 insertions(+), 18 deletions(-)
Index: linux-mcount.git/lib/tracing/tracer.h
===================================================================
--- linux-mcount.git.orig/lib/tracing/tracer.h 2008-01-25 21:47:25.000000000 -0500
+++ linux-mcount.git/lib/tracing/tracer.h 2008-01-25 21:47:27.000000000 -0500
@@ -112,4 +112,18 @@ static inline notrace cycle_t now(void)
return get_monotonic_cycles();
}
+#ifdef CONFIG_CONTEXT_SWITCH_TRACER
+typedef void (*tracer_switch_func_t)(void *private,
+ struct task_struct *prev,
+ struct task_struct *next);
+struct tracer_switch_ops {
+ tracer_switch_func_t func;
+ void *private;
+ struct tracer_switch_ops *next;
+};
+
+extern int register_tracer_switch(struct tracer_switch_ops *ops);
+extern int unregister_tracer_switch(struct tracer_switch_ops *ops);
+#endif /* CONFIG_CONTEXT_SWITCH_TRACER */
+
#endif /* _LINUX_MCOUNT_TRACER_H */
Index: linux-mcount.git/lib/tracing/trace_sched_switch.c
===================================================================
--- linux-mcount.git.orig/lib/tracing/trace_sched_switch.c 2008-01-25 21:47:25.000000000 -0500
+++ linux-mcount.git/lib/tracing/trace_sched_switch.c 2008-01-25 21:47:27.000000000 -0500
@@ -16,33 +16,21 @@
static struct tracing_trace *tracer_trace;
static int trace_enabled __read_mostly;
+static DEFINE_SPINLOCK(sched_switch_func_lock);
-static notrace void sched_switch_callback(const struct marker *mdata,
- void *private_data,
- const char *format, ...)
+static void notrace sched_switch_func(void *private,
+ struct task_struct *prev,
+ struct task_struct *next)
{
- struct tracing_trace **p = mdata->private;
- struct tracing_trace *tr = *p;
+ struct tracing_trace **ptr = private;
+ struct tracing_trace *tr = *ptr;
struct tracing_trace_cpu *data;
- struct task_struct *prev;
- struct task_struct *next;
unsigned long flags;
- va_list ap;
int cpu;
- if (likely(!atomic_read(&trace_record_cmdline)))
- return;
-
- tracing_record_cmdline(current);
-
if (likely(!trace_enabled))
return;
- va_start(ap, format);
- prev = va_arg(ap, typeof(prev));
- next = va_arg(ap, typeof(next));
- va_end(ap);
-
raw_local_irq_save(flags);
cpu = raw_smp_processor_id();
data = tr->data[cpu];
@@ -55,6 +43,105 @@ static notrace void sched_switch_callbac
raw_local_irq_restore(flags);
}
+static struct tracer_switch_ops sched_switch_ops __read_mostly =
+{
+ .func = sched_switch_func,
+ .private = &tracer_trace,
+};
+
+static tracer_switch_func_t tracer_switch_func __read_mostly =
+ sched_switch_func;
+
+static struct tracer_switch_ops *tracer_switch_func_ops __read_mostly =
+ &sched_switch_ops;
+
+static void notrace sched_switch_func_loop(void *private,
+ struct task_struct *prev,
+ struct task_struct *next)
+{
+ struct tracer_switch_ops *ops = tracer_switch_func_ops;
+
+ for (; ops != NULL; ops = ops->next)
+ ops->func(ops->private, prev, next);
+}
+
+notrace int register_tracer_switch(struct tracer_switch_ops *ops)
+{
+ unsigned long flags;
+
+ spin_lock_irqsave(&sched_switch_func_lock, flags);
+ ops->next = tracer_switch_func_ops;
+ smp_wmb();
+ tracer_switch_func_ops = ops;
+
+ if (ops->next == &sched_switch_ops)
+ tracer_switch_func = sched_switch_func_loop;
+
+ spin_unlock_irqrestore(&sched_switch_func_lock, flags);
+
+ return 0;
+}
+
+notrace int unregister_tracer_switch(struct tracer_switch_ops *ops)
+{
+ unsigned long flags;
+ struct tracer_switch_ops **p = &tracer_switch_func_ops;
+ int ret;
+
+ spin_lock_irqsave(&sched_switch_func_lock, flags);
+
+ /*
+ * If the sched_switch is the only one left, then
+ * only call that function.
+ */
+ if (*p == ops && ops->next == &sched_switch_ops) {
+ tracer_switch_func = sched_switch_func;
+ tracer_switch_func_ops = &sched_switch_ops;
+ goto out;
+ }
+
+ for (; *p != &sched_switch_ops; p = &(*p)->next)
+ if (*p == ops)
+ break;
+
+ if (*p != ops) {
+ ret = -1;
+ goto out;
+ }
+
+ *p = (*p)->next;
+
+ out:
+ spin_unlock_irqrestore(&sched_switch_func_lock, flags);
+
+ return 0;
+}
+
+static notrace void sched_switch_callback(const struct marker *mdata,
+ void *private_data,
+ const char *format, ...)
+{
+ struct task_struct *prev;
+ struct task_struct *next;
+ va_list ap;
+
+ if (likely(!atomic_read(&trace_record_cmdline)))
+ return;
+
+ tracing_record_cmdline(current);
+
+ va_start(ap, format);
+ prev = va_arg(ap, typeof(prev));
+ next = va_arg(ap, typeof(next));
+ va_end(ap);
+
+ /*
+ * If tracer_switch_func only points to the local
+ * switch func, it still needs the ptr passed to it.
+ */
+ tracer_switch_func(mdata->private, prev, next);
+}
+
static notrace void sched_switch_reset(struct tracing_trace *tr)
{
int cpu;
--
next prev parent reply other threads:[~2008-01-26 4:35 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-26 4:21 [PATCH 00/23 -v6] mcount and latency tracing utility -v6 Steven Rostedt
2008-01-26 4:21 ` [PATCH 01/23 -v6] printk - dont wakeup klogd with interrupts disabled Steven Rostedt
2008-01-26 9:10 ` Pavel Machek
2008-01-26 9:52 ` Peter Zijlstra
2008-01-26 13:07 ` Steven Rostedt
2008-01-26 13:48 ` Steven Rostedt
2008-01-26 9:50 ` Peter Zijlstra
2008-01-26 13:03 ` Steven Rostedt
2008-01-26 4:21 ` [PATCH 02/23 -v6] Add basic support for gcc profiler instrumentation Steven Rostedt
2008-01-26 4:21 ` [PATCH 03/23 -v6] Annotate core code that should not be traced Steven Rostedt
2008-01-26 4:21 ` [PATCH 04/23 -v6] x86_64: notrace annotations Steven Rostedt
2008-01-26 4:21 ` [PATCH 05/23 -v6] add notrace annotations to vsyscall Steven Rostedt
2008-01-26 4:21 ` [PATCH 06/23 -v6] add notrace annotations for NMI routines Steven Rostedt
2008-01-26 4:21 ` [PATCH 07/23 -v6] handle accurate time keeping over long delays Steven Rostedt
2008-01-26 4:22 ` [PATCH 08/23 -v6] initialize the clock source to jiffies clock Steven Rostedt
2008-01-26 4:22 ` [PATCH 09/23 -v6] add get_monotonic_cycles Steven Rostedt
2008-01-26 4:22 ` [PATCH 10/23 -v6] add notrace annotations to timing events Steven Rostedt
2008-01-26 4:22 ` [PATCH 11/23 -v6] mcount based trace in the form of a header file library Steven Rostedt
2008-01-26 4:22 ` [PATCH 12/23 -v6] Add context switch marker to sched.c Steven Rostedt
2008-01-26 4:22 ` [PATCH 13/23 -v6] Make the task State char-string visible to all Steven Rostedt
2008-01-26 4:22 ` [PATCH 14/23 -v6] Add tracing of context switches Steven Rostedt
2008-01-26 4:22 ` [PATCH 15/23 -v6] Generic command line storage Steven Rostedt
2008-01-26 4:22 ` Steven Rostedt [this message]
2008-01-26 4:22 ` [PATCH 17/23 -v6] Add marker in try_to_wake_up Steven Rostedt
2008-01-26 4:22 ` [PATCH 18/23 -v6] mcount tracer for wakeup latency timings Steven Rostedt
2008-01-26 4:22 ` [PATCH 19/23 -v6] Trace irq disabled critical timings Steven Rostedt
2008-01-26 4:22 ` [PATCH 20/23 -v6] trace preempt off " Steven Rostedt
2008-01-26 4:22 ` [PATCH 21/23 -v6] Add markers to various events Steven Rostedt
2008-01-26 4:22 ` [PATCH 22/23 -v6] Add event tracer Steven Rostedt
2008-01-26 4:22 ` [PATCH 23/23 -v6] Critical latency timings histogram Steven Rostedt
2008-01-26 9:11 ` Pavel Machek
2008-01-26 13:00 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080126042803.686515731@goodmis.org \
--to=rostedt@goodmis.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=akpm@linux-foundation.org \
--cc=arjan@infradead.org \
--cc=fche@redhat.com \
--cc=ghaskins@novell.com \
--cc=hch@infradead.org \
--cc=jan.kiszka@siemens.com \
--cc=johnstul@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@polymtl.ca \
--cc=mingo@elte.hu \
--cc=pavel@ucw.cz \
--cc=sam@ravnborg.org \
--cc=srostedt@redhat.com \
--cc=tglx@linutronix.de \
--cc=tim.bird@am.sony.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox