From: "Mark M. Hoffman" <mhoffman@lightlink.com>
To: "Darrick J. Wong" <djwong@us.ibm.com>
Cc: Jean Delvare <khali@linux-fr.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
lm-sensors <lm-sensors@lm-sensors.org>
Subject: Re: [lm-sensors] [PATCH] adt7470: Support per-sensor alarm files
Date: Sun, 27 Jan 2008 09:39:03 -0500 [thread overview]
Message-ID: <20080127143903.GC29892@jupiter.solarsys.private> (raw)
In-Reply-To: <20071219221124.GP6870@tree.beaverton.ibm.com>
Hi Darrick:
* Darrick J. Wong <djwong@us.ibm.com> [2007-12-19 14:11:25 -0800]:
> On Wed, Dec 19, 2007 at 03:40:12PM +0100, Jean Delvare wrote:
> > In general we keep the all-in-one alarms file for compatibility, but
> > given that this driver is fairly new and libsensors never had specific
> > support for it anyway, it's probably OK to drop it this time.
>
> Thanks for the code review. I've made the changes you asked for and
> here's a new patch to supersede yesterday's.
> ---
> Remove the old alarms hack and replace it with per-sensor alarm files.
>
> Signed-off-by: Darrick J. Wong <djwong@us.ibm.com>
> ---
>
> drivers/hwmon/adt7470.c | 96 +++++++++++++++++++++++++++++++++++++++++------
> 1 files changed, 84 insertions(+), 12 deletions(-)
Applied to hwmon-2.6.git/testing, thanks.
--
Mark M. Hoffman
mhoffman@lightlink.com
prev parent reply other threads:[~2008-01-27 14:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-19 4:01 [PATCH] adt7470: Support per-sensor alarm files Darrick J. Wong
2007-12-19 14:40 ` Jean Delvare
2007-12-19 22:11 ` Darrick J. Wong
2007-12-20 9:58 ` Jean Delvare
2007-12-20 18:57 ` Darrick J. Wong
2007-12-22 11:34 ` Jean Delvare
2008-01-27 14:39 ` Mark M. Hoffman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080127143903.GC29892@jupiter.solarsys.private \
--to=mhoffman@lightlink.com \
--cc=djwong@us.ibm.com \
--cc=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox