public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Steven Rostedt <srostedt@redhat.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Dmitry Adamushko <dmitry.adamushko@gmail.com>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [Regression] 2.6.24-git3: Major annoyance during suspend/hibernation on x86-64 (bisected)
Date: Sun, 27 Jan 2008 22:59:04 +0100	[thread overview]
Message-ID: <20080127215904.GB2686@elte.hu> (raw)
In-Reply-To: <200801272229.48955.rjw@sisk.pl>


* Rafael J. Wysocki <rjw@sisk.pl> wrote:

> Hi,
> 
> 2.6.24-git3 adds a 5 - 10 sec delay to the suspend and hibernation 
> code paths (probably related to the disabling of nonboot CPUs), which 
> is !@#$%^&*() annoying.
> 
> It's 100% reproducible on my HP nx6325 and bisection idendified the 
> following commit as the first bad one:
> 
> commit 764a9d6fe4b52995c8aba277e3634385699354f4
> Author: Steven Rostedt <srostedt@redhat.com>
> Date:   Fri Jan 25 21:08:04 2008 +0100
> 
>     sched: track highest prio task queued

hm, this patch is a NOP, so it's weird that it has an effect.

Do you have serial logging enabled perhaps? If the following WARN_ON() 
triggers:

+               WARN_ON(p->prio < rq->rt.highest_prio);

then perhaps that can cause a 5-10 seconds delay. (that's how much time 
it takes to printk a warning on the slowest serial settings)

but if you use suspend, then any such printks would be preserved in the 
dmesg, right? If the WARN_ON() triggers, and if you remove it, do things 
get faster?

this does have the feel of being scheduling related, but are you 
absolutely sure about the precise identity of the patch? It's not the 
next patch or the preceding patch by any chance? (which would also be 
scheduler patches)

	Ingo

  reply	other threads:[~2008-01-27 21:59 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-27 21:29 [Regression] 2.6.24-git3: Major annoyance during suspend/hibernation on x86-64 (bisected) Rafael J. Wysocki
2008-01-27 21:59 ` Ingo Molnar [this message]
2008-01-28  1:26   ` Rafael J. Wysocki
2008-01-28  1:40     ` Steven Rostedt
2008-01-28 11:31       ` Rafael J. Wysocki
2008-01-28 16:31         ` Rafael J. Wysocki
2008-01-28 16:46           ` Steven Rostedt
2008-01-29  0:08           ` Rafael J. Wysocki
2008-01-28  8:56     ` Dmitry Adamushko
2008-01-28 11:32       ` Rafael J. Wysocki
2008-01-28 16:08       ` Rafael J. Wysocki
2008-01-31 15:58     ` Peter Zijlstra
2008-01-31 20:54       ` Rafael J. Wysocki
2008-02-01 12:04         ` Peter Zijlstra
2008-02-01 12:47           ` Ingo Molnar
2008-02-01 14:42             ` Rafael J. Wysocki
2008-02-01 23:19               ` Rafael J. Wysocki
2008-02-01 23:24                 ` Ingo Molnar
2008-02-01 15:11           ` Dmitry Adamushko
2008-02-01 17:10             ` Ingo Molnar
2008-02-01 21:54               ` Dmitry Adamushko
2008-02-01 22:44                 ` Dmitry Adamushko
2008-02-01 22:48                   ` Ingo Molnar
2008-02-01 23:22                     ` Dmitry Adamushko
2008-02-01 23:25                       ` Ingo Molnar
2008-02-02  0:03                         ` Dmitry Adamushko
2008-02-01 23:26                       ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080127215904.GB2686@elte.hu \
    --to=mingo@elte.hu \
    --cc=a.p.zijlstra@chello.nl \
    --cc=akpm@linux-foundation.org \
    --cc=dmitry.adamushko@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rjw@sisk.pl \
    --cc=srostedt@redhat.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox