[patch 3/3] x86: deprecate change_page_attr() for drivers

[patch 3/3] x86: deprecate change_page_attr() for drivers

[Arjan van de Ven]

Subject: x86: deprecate change_page_attr()
From: Arjan van de Ven <arjan@linux.intel.com>

With the introduction of the new API, no driver or non-archcore code needs
to use c-p-a anymore, so this patch also deprecates the EXPORT_SYMBOL of CPA
(it's a horrible API after all).

Signed-off-by: Arjan van de Ven <arjan@linux.intel.com>

---
 arch/x86/mm/pageattr.c       |    2 +-
 include/asm-x86/cacheflush.h |    3 ++-
 2 files changed, 3 insertions(+), 2 deletions(-)

Index: linux.trees.git/arch/x86/mm/pageattr.c
===================================================================
--- linux.trees.git.orig/arch/x86/mm/pageattr.c
+++ linux.trees.git/arch/x86/mm/pageattr.c
@@ -288,7 +288,7 @@ int change_page_attr(struct page *page, 
 
 	return change_page_attr_addr(addr, numpages, prot);
 }
-EXPORT_SYMBOL(change_page_attr);
+EXPORT_UNUSED_SYMBOL(change_page_attr); /* to be removed in 2.6.27 */
 
 /**
  * change_page_attr_set - Change page table attributes in the linear mapping.
Index: linux.trees.git/include/asm-x86/cacheflush.h
===================================================================
--- linux.trees.git.orig/include/asm-x86/cacheflush.h
+++ linux.trees.git/include/asm-x86/cacheflush.h
@@ -25,7 +25,8 @@
 	memcpy(dst, src, len)
 
 void global_flush_tlb(void);
-int change_page_attr(struct page *page, int numpages, pgprot_t prot);
+int __deprecated_for_modules change_page_attr(struct page *page, int numpages,
+								pgprot_t prot);
 int change_page_attr_addr(unsigned long addr, int numpages, pgprot_t prot);
 
 int set_pages_uc(struct page *page, int numpages);


-- 
If you want to reach me at my work email, use arjan@linux.intel.com
For development, discussion and tips for power savings, 
visit http://www.lesswatts.org

Re: [patch 3/3] x86: deprecate change_page_attr() for drivers

[Ingo Molnar]

* Arjan van de Ven <arjan@infradead.org> wrote:

> Subject: x86: deprecate change_page_attr()
> From: Arjan van de Ven <arjan@linux.intel.com>
> 
> With the introduction of the new API, no driver or non-archcore code 
> needs to use c-p-a anymore, so this patch also deprecates the 
> EXPORT_SYMBOL of CPA (it's a horrible API after all).

agreed. Nice changes :)

	Ingo