From: Andy Whitcroft <apw@shadowen.org>
To: Paolo Ciarrocchi <paolo.ciarrocchi@gmail.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Change a WARN message in checkpatch
Date: Mon, 28 Jan 2008 14:56:05 +0000 [thread overview]
Message-ID: <20080128145605.GI12910@shadowen.org> (raw)
In-Reply-To: <20080114232913.2555d392@paolo-desktop>
On Mon, Jan 14, 2008 at 11:29:13PM +0100, Paolo Ciarrocchi wrote:
> Hi Andy,
> When I started using checkpatch I was confused by the following WARN message:
>
> no space between function name and open parenthesis
>
> I thought the problem was that a space was missing while the truth is the opposite.
>
> How about the following patch?
I can see how that language would be confusing. Your patch makes the
english clearer, but somehow seems clumsy. There must be a better way
to say this. I will think on it and see what I can come up with.
-apw
next prev parent reply other threads:[~2008-01-28 14:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-14 22:29 [PATCH] Change a WARN message in checkpatch Paolo Ciarrocchi
2008-01-28 14:56 ` Andy Whitcroft [this message]
2008-01-28 15:13 ` Paolo Ciarrocchi
2008-02-23 13:38 ` Paolo Ciarrocchi
2008-02-24 15:18 ` Benny Halevy
2008-02-24 18:14 ` Paolo Ciarrocchi
2008-02-25 3:29 ` Andy Whitcroft
2008-02-25 5:47 ` Benny Halevy
2008-02-25 6:51 ` Paolo Ciarrocchi
2008-02-25 10:53 ` Andy Whitcroft
-- strict thread matches above, loose matches on Subject: below --
2008-01-04 12:45 Paolo Ciarrocchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080128145605.GI12910@shadowen.org \
--to=apw@shadowen.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paolo.ciarrocchi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox