From: Andy Whitcroft <apw@shadowen.org>
To: Andi Kleen <ak@suse.de>
Cc: rdunlap@xenotime.net, jschopp@austin.ibm.com, akpm@osdl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Deprecate checkpatch.pl --file mode; add warning; add --file-force
Date: Mon, 28 Jan 2008 14:59:11 +0000 [thread overview]
Message-ID: <20080128145911.GJ12910@shadowen.org> (raw)
In-Reply-To: <20080116222121.GA7185@wotan.suse.de>
On Wed, Jan 16, 2008 at 11:21:21PM +0100, Andi Kleen wrote:
> Deprecate checkpatch.pl --file mode; add warning; add --file-force
>
> As discussed on linux-kernel checkpatch.pl only patches for whole
> files have a significant cost. Better such changes should be only
> done together with other changes. Add a explicit warning about
> this; deprecate --file and add a --file-force instead.
>
> Signed-off-by: Andi Kleen <ak@suse.de>
Cirtainly I can see why we want this
warning out there and very much in the submitters face, it just feels a
little heavy handed to make them change option to get the result.
Would not just always appending this message in --file mode always be
just as effective? Perhaps suppressing it with -q, or with some new "i
know what I am doing" option?
-apw
prev parent reply other threads:[~2008-01-28 14:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-16 22:21 [PATCH] Deprecate checkpatch.pl --file mode; add warning; add --file-force Andi Kleen
2008-01-16 23:17 ` Andy Whitcroft
2008-01-28 14:59 ` Andy Whitcroft [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080128145911.GJ12910@shadowen.org \
--to=apw@shadowen.org \
--cc=ak@suse.de \
--cc=akpm@osdl.org \
--cc=jschopp@austin.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@xenotime.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox