From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757408AbYA1U3X (ORCPT ); Mon, 28 Jan 2008 15:29:23 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754745AbYA1U3G (ORCPT ); Mon, 28 Jan 2008 15:29:06 -0500 Received: from smtp6.pp.htv.fi ([213.243.153.40]:40588 "EHLO smtp6.pp.htv.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752549AbYA1U3D (ORCPT ); Mon, 28 Jan 2008 15:29:03 -0500 Date: Mon, 28 Jan 2008 22:29:29 +0200 From: Adrian Bunk To: Mike Frysinger Cc: ltp-list@lists.sourceforge.net, risrajak@in.ibm.com, linux-kernel@vger.kernel.org Subject: Re: [LTP] [TEST] : LTP Build failure on 2.6.24 kernel Message-ID: <20080128202929.GB8767@does.not.exist> References: <1201508081.4029.4.camel@localhost.localdomain> <200801280653.16624.vapier@gentoo.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <200801280653.16624.vapier@gentoo.org> User-Agent: Mutt/1.5.17+20080114 (2008-01-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 28, 2008 at 06:53:15AM -0500, Mike Frysinger wrote: > On Monday 28 January 2008, Rishikesh K. Rajak wrote: > > Here i am getting failure on the x86_64 machine with new kernel. > > > > Here is the uname for that machine: > > > > rishi@:~/ltp-full-20071231# uname -a > > Linux rishi.in.ibm.com 2.6.24 #1 SMP PREEMPT Mon Jan 28 06:47:28 UTC > > 2008 x86_64 GNU/Linux > > i'm guessing you're using ubuntu and thus dash is your /bin/sh ... shouldnt be > a 2.6.24 issue > > > make[4]: Entering directory > > `/root/ltp-full-20071231/testcases/network/tcp_cmds/ftp' > > ../../generate.sh > > ../../generate.sh: 60: arith: syntax error: "cnt=cnt-1" > > sadly, this is becoming a FAQ. ubuntu ships a broken /bin/sh (dash) and thus > some LTP scripts fall apart. i would prefer to not change the scripts as the > message is simple in LTP: fix your shell, dont add hacks to LTP. otherwise > we slowly back ourselves into this corner with the shell scripts where we try > to support every craptastic shell out there and we're afraid to make any > changes because we dont know what crappy shell is going to drop a brick. LTP > scripts are written to be POSIX complaint and only POSIX complaint shells > should be provided by /bin/sh. You better fulfil your claim "LTP scripts are written to be POSIX complaint" before complaining about shells being unhappy with your script. E.g. where in IEEE 1003.1-2004 is the "local" you use specified? Or instead of working on making your script using only the stuff specified in IEEE 1003.1-2004 you could simply replace the #!/bin/sh at the top with a #!/bin/bash and everbody will be happy. > -mike cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed