From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1765288AbYA1XZJ (ORCPT ); Mon, 28 Jan 2008 18:25:09 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1764938AbYA1XTV (ORCPT ); Mon, 28 Jan 2008 18:19:21 -0500 Received: from palinux.external.hp.com ([192.25.206.14]:38994 "EHLO mail.parisc-linux.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1764045AbYA1XTT (ORCPT ); Mon, 28 Jan 2008 18:19:19 -0500 Date: Mon, 28 Jan 2008 16:19:18 -0700 From: Matthew Wilcox To: linux-arch@vger.kernel.org Cc: linux-kernel@vger.kernel.org Subject: down_killable implementations for every architecture Message-ID: <20080128231918.GB31101@parisc-linux.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.13 (2006-08-11) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org As part of the TASK_KILLABLE changes, we're going to need down_killable(). Unfortunately, semaphores are implemented for every architecture, which we should probably fix at some point. On the plane ride down here, I did the necessary changes for each architecture: http://parisc-linux.org/~willy/down-killable/ I may have made mistakes. Things to check: - The *_killable* functions should be exported for use by modules. - The down_killable implementation needs to check fatal_signal_pending, not signal_pending. - The task state needs to be set to TASK_KILLABLE, not TASK_INTERRUPTIBLE It should only take a couple of minutes to verify your architecture. -- Intel are signing my paycheques ... these opinions are still mine "Bill, look, we understand that you're interested in selling us this operating system, but compare it to ours. We can't possibly take such a retrograde step."