Re: [PATCH 6/7] X86: include missing KERN_ facility level

Paolo Ciarrocchi
2008-01-31T22:58:16Z

On 1/29/08, Joe Perches <joe@perches.com> wrote:
> On Tue, 2008-01-29 at 00:08 +0100, Paolo Ciarrocchi wrote:
> > \diff --git a/arch/x86/math-emu/errors.c b/arch/x86/math-emu/errors.c
> > index 6102fe0..569a62e 100644
> > --- a/arch/x86/math-emu/errors.c
> > +++ b/arch/x86/math-emu/errors.c
> > @@ -57,65 +57,65 @@ void FPU_printall(void)
> >
> > RE_ENTRANT_CHECK_OFF;
> > /* No need to check access_ok(), we have previously fetched these
> bytes. */
> > - printk("At %p:", (void *) address);
> > + printk(KERN_ERR "At %p:", (void *) address);
> > if (FPU_CS == __USER_CS) {
> > #define MAX_PRINTED_BYTES 20
> > for (i = 0; i < MAX_PRINTED_BYTES; i++) {
> > FPU_get_user(byte1, (u_char __user *) address);
> > if ((byte1 & 0xf8) == 0xd8) {
> > - printk(" %02x", byte1);
> > + printk(KERN_ERR " %02x", byte1);
> > break;
> > }
> > - printk(" [%02x]", byte1);
> > + printk(KERN_ERR " [%02x]", byte1);
> > address++;
> > }
>
> KERN_ prefixes are used only at the start of a line.
> You should probably use print_hex_dump.

Thank you. I'll redo the patch.

Ciao,
--
Paolo