Re: [PATCH 1/2] IRQ_NOPROBE helper functions

Rob Landley
2008-01-31T07:56:48Z

On Tuesday 29 January 2008 05:20:48 Ralf Baechle wrote:
> Probing non-ISA interrupts using the handle_percpu_irq as their handle_irq
> method may crash the system because handle_percpu_irq does not check
> IRQ_WAITING. This for example hits the MIPS Qemu configuration.
>
> This patch provides two helper functions set_irq_noprobe and set_irq_probe
> to set rsp. clear the IRQ_NOPROBE flag. The only current caller is MIPS
> code but this really belongs into generic code.
>
> As an aside, interrupt probing these days has become a mostly obsolete if
> not dangerous art. I think Linux interrupts should be changed to default
> to non-probing but that's subject of this patch.
>
> Signed-off-by: Ralf Baechle <ralf@linux-mips.org>

Acked-by: Rob Landley <rob@landley.net>

To both patches: I can confirm that applying these two fixes together avoids
the panic for me, although I thought qemu-system-mips used to have a working
RTC, and I can't seem to find it now. (Make is unhappy with 1970. It was
not a good year for make...)

Thanks,