From: Oliver Neukum <oliver@neukum.org>
To: Tobias Lorenz <tobias.lorenz@gmx.net>
Cc: Mauro Carvalho Chehab <mchehab@infradead.org>,
Adrian Bunk <bunk@kernel.org>,
video4linux-list@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] radio-si470x.c: check-after-use
Date: Tue, 29 Jan 2008 20:37:36 +0100 [thread overview]
Message-ID: <200801292037.36647.oliver@neukum.org> (raw)
In-Reply-To: <200801282343.13589.tobias.lorenz@gmx.net>
Am Montag 28 Januar 2008 schrieb Tobias Lorenz:
> > Either "radio" can be NULL and this case has to be properly handled or
> > the NULL check is not required.
>
> These two lines should indeed better be inside the if statement. The patch for this is below.
No, in disconnect intfdata must be valid. Any check for NULL is wrong
there.
Regards
Oliver
next prev parent reply other threads:[~2008-01-29 19:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-28 22:13 media/radio/radio-si470x.c: check-after-use Adrian Bunk
2008-01-28 22:43 ` [PATCH] radio-si470x.c: check-after-use Tobias Lorenz
2008-01-29 19:37 ` Oliver Neukum [this message]
2008-01-29 20:37 ` Tobias Lorenz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200801292037.36647.oliver@neukum.org \
--to=oliver@neukum.org \
--cc=bunk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=tobias.lorenz@gmx.net \
--cc=video4linux-list@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox