Re: [PATCH 19/22 -v7] trace preempt off critical timings

Steven Rostedt
2008-01-30T13:40:59Z

On Wed, 30 Jan 2008, Peter Zijlstra wrote:

>
> On Tue, 2008-01-29 at 22:15 -0500, Steven Rostedt wrote:
>
> > +static DEFINE_PER_CPU(int, tracing_cpu);
>
> Is the per-cpu tracing not also needed for irq off tracing?

The preempt off code shares the irq off code. With irq off only (before
this patch) all that was needed was to check if trace_enabled is set or
not. Now that the preempt off code is coupled with the irqs off code, we
may hit some paths where tracing is enabled but we are not currently
tracing. This variable was added to facilitate this knowledge.

>
> Also, its not mentioned in the changelog.

It was more of an internal design change than a feature.

-- Steve