From: Steven Rostedt <rostedt@goodmis.org>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Ingo Molnar <mingo@elte.hu>,
Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Christoph Hellwig <hch@infradead.org>,
Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>,
Gregory Haskins <ghaskins@novell.com>,
Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
Thomas Gleixner <tglx@linutronix.de>,
Tim Bird <tim.bird@am.sony.com>, Sam Ravnborg <sam@ravnborg.org>,
"Frank Ch. Eigler" <fche@redhat.com>,
Jan Kiszka <jan.kiszka@siemens.com>,
John Stultz <johnstul@us.ibm.com>,
Arjan van de Ven <arjan@infradead.org>
Subject: [PATCH 07/22 -v7] initialize the clock source to jiffies clock.
Date: Tue, 29 Jan 2008 22:15:28 -0500 [thread overview]
Message-ID: <20080130031841.148149808@goodmis.org> (raw)
In-Reply-To: 20080130031521.258552785@goodmis.org
[-- Attachment #1: initialize-clocksource-to-jiffies.patch --]
[-- Type: text/plain, Size: 2086 bytes --]
The latency tracer can call clocksource_read very early in bootup and
before the clock source variable has been initialized. This results in a
crash at boot up (even before earlyprintk is initialized). Since the
clock->read variable points to NULL.
This patch simply initializes the clock to use clocksource_jiffies, so
that any early user of clocksource_read will not crash.
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
Acked-by: John Stultz <johnstul@us.ibm.com>
---
include/linux/clocksource.h | 3 +++
kernel/time/timekeeping.c | 9 +++++++--
2 files changed, 10 insertions(+), 2 deletions(-)
Index: linux-mcount.git/include/linux/clocksource.h
===================================================================
--- linux-mcount.git.orig/include/linux/clocksource.h 2008-01-25 21:47:09.000000000 -0500
+++ linux-mcount.git/include/linux/clocksource.h 2008-01-25 21:47:11.000000000 -0500
@@ -273,6 +273,9 @@ extern struct clocksource* clocksource_g
extern void clocksource_change_rating(struct clocksource *cs, int rating);
extern void clocksource_resume(void);
+/* used to initialize clock */
+extern struct clocksource clocksource_jiffies;
+
#ifdef CONFIG_GENERIC_TIME_VSYSCALL
extern void update_vsyscall(struct timespec *ts, struct clocksource *c);
extern void update_vsyscall_tz(void);
Index: linux-mcount.git/kernel/time/timekeeping.c
===================================================================
--- linux-mcount.git.orig/kernel/time/timekeeping.c 2008-01-25 21:47:09.000000000 -0500
+++ linux-mcount.git/kernel/time/timekeeping.c 2008-01-25 21:47:11.000000000 -0500
@@ -53,8 +53,13 @@ static inline void update_xtime_cache(u6
timespec_add_ns(&xtime_cache, nsec);
}
-static struct clocksource *clock; /* pointer to current clocksource */
-
+/*
+ * pointer to current clocksource
+ * Just in case we use clocksource_read before we initialize
+ * the actual clock source. Instead of calling a NULL read pointer
+ * we return jiffies.
+ */
+static struct clocksource *clock = &clocksource_jiffies;
#ifdef CONFIG_GENERIC_TIME
/**
--
next prev parent reply other threads:[~2008-01-30 3:21 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-30 3:15 [PATCH 00/22 -v7] mcount and latency tracing utility -v7 Steven Rostedt
2008-01-30 3:15 ` [PATCH 01/22 -v7] printk - dont wakeup klogd with interrupts disabled Steven Rostedt
2008-01-30 3:15 ` [PATCH 02/22 -v7] Add basic support for gcc profiler instrumentation Steven Rostedt
2008-01-30 8:46 ` Peter Zijlstra
2008-01-30 13:08 ` Steven Rostedt
2008-01-30 14:09 ` Steven Rostedt
2008-01-30 14:25 ` Peter Zijlstra
2008-02-01 22:34 ` Paul E. McKenney
2008-02-02 1:56 ` Steven Rostedt
2008-02-02 21:41 ` Paul E. McKenney
2008-02-04 17:09 ` Steven Rostedt
2008-02-04 21:40 ` Paul E. McKenney
2008-02-04 22:03 ` Steven Rostedt
2008-02-04 22:41 ` Mathieu Desnoyers
2008-02-05 6:11 ` Paul E. McKenney
2008-02-05 5:13 ` Paul E. McKenney
2008-01-30 13:21 ` Jan Kiszka
2008-01-30 13:53 ` Steven Rostedt
2008-01-30 14:28 ` Steven Rostedt
2008-01-30 3:15 ` [PATCH 03/22 -v7] Annotate core code that should not be traced Steven Rostedt
2008-01-30 3:15 ` [PATCH 04/22 -v7] x86_64: notrace annotations Steven Rostedt
2008-01-30 3:15 ` [PATCH 05/22 -v7] add notrace annotations to vsyscall Steven Rostedt
2008-01-30 8:49 ` Peter Zijlstra
2008-01-30 13:15 ` Steven Rostedt
2008-01-30 3:15 ` [PATCH 06/22 -v7] handle accurate time keeping over long delays Steven Rostedt
2008-01-30 3:15 ` Steven Rostedt [this message]
2008-01-30 3:15 ` [PATCH 08/22 -v7] add get_monotonic_cycles Steven Rostedt
2008-01-30 3:15 ` [PATCH 09/22 -v7] add notrace annotations to timing events Steven Rostedt
2008-01-30 3:15 ` [PATCH 10/22 -v7] mcount based trace in the form of a header file library Steven Rostedt
2008-01-30 3:15 ` [PATCH 11/22 -v7] Add context switch marker to sched.c Steven Rostedt
2008-01-30 3:15 ` [PATCH 12/22 -v7] Make the task State char-string visible to all Steven Rostedt
2008-01-30 3:15 ` [PATCH 13/22 -v7] Add tracing of context switches Steven Rostedt
2008-01-30 3:15 ` [PATCH 14/22 -v7] Generic command line storage Steven Rostedt
2008-01-30 3:15 ` [PATCH 15/22 -v7] trace generic call to schedule switch Steven Rostedt
2008-01-30 3:15 ` [PATCH 16/22 -v7] Add marker in try_to_wake_up Steven Rostedt
2008-01-30 3:15 ` [PATCH 17/22 -v7] mcount tracer for wakeup latency timings Steven Rostedt
2008-01-30 9:31 ` Peter Zijlstra
2008-01-30 13:18 ` Steven Rostedt
2008-01-30 3:15 ` [PATCH 18/22 -v7] Trace irq disabled critical timings Steven Rostedt
2008-01-30 3:15 ` [PATCH 19/22 -v7] trace preempt off " Steven Rostedt
2008-01-30 9:40 ` Peter Zijlstra
2008-01-30 13:40 ` Steven Rostedt
2008-01-30 3:15 ` [PATCH 20/22 -v7] Add markers to various events Steven Rostedt
2008-01-30 3:15 ` [PATCH 21/22 -v7] Add event tracer Steven Rostedt
2008-01-30 3:15 ` [PATCH 22/22 -v7] Critical latency timings histogram Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080130031841.148149808@goodmis.org \
--to=rostedt@goodmis.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=akpm@linux-foundation.org \
--cc=arjan@infradead.org \
--cc=fche@redhat.com \
--cc=ghaskins@novell.com \
--cc=hch@infradead.org \
--cc=jan.kiszka@siemens.com \
--cc=johnstul@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@polymtl.ca \
--cc=mingo@elte.hu \
--cc=sam@ravnborg.org \
--cc=tglx@linutronix.de \
--cc=tim.bird@am.sony.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox