The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: Bryan Wu <bryan.wu@analog.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] [Scripts] add svn revision information to setlocalversion
Date: Wed, 30 Jan 2008 11:24:42 +0100	[thread overview]
Message-ID: <20080130102442.GB20846@uranus.ravnborg.org> (raw)
In-Reply-To: <1201688125-1387-1-git-send-email-bryan.wu@analog.com>

On Wed, Jan 30, 2008 at 06:15:25PM +0800, Bryan Wu wrote:
> Signed-off-by: Bryan Wu <bryan.wu@analog.com>
> ---
>  scripts/setlocalversion |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
> 
> diff --git a/scripts/setlocalversion b/scripts/setlocalversion
> index 52f032e..2d6645c 100644
> --- a/scripts/setlocalversion
> +++ b/scripts/setlocalversion
> @@ -25,6 +25,10 @@ if head=`git rev-parse --verify HEAD 2>/dev/null`; then
>  	# All done with git
>  	exit
>  fi
> +# Check for svn and a svn repo.
> +if rev=`svn info 2>/dev/null | grep '^Revision' | awk '{print $NF}'` ; then
> +        printf -- '-svn%s' $rev
> +fi
>  
>  # Check for mercurial and a mercurial repo.
>  if hgid=`hg id 2>/dev/null`; then

Hi Bryna.

Can I ask you to change the shell script to use
a chained if so if we find git we do not try mercurial nor svn.

I should have done so initially when adding the patch with mercurial
support but it slipped my mind.

	Sam

  reply	other threads:[~2008-01-30 10:24 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-30 10:15 [PATCH 1/1] [Scripts] add svn revision information to setlocalversion Bryan Wu
2008-01-30 10:24 ` Sam Ravnborg [this message]
2008-01-30 16:00   ` Bryan Wu
2008-01-30 16:39   ` [PATCH 1/1 try#2] " Bryan Wu
2008-02-02 18:24     ` Sam Ravnborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080130102442.GB20846@uranus.ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=bryan.wu@analog.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox