From: Oleg Nesterov <oleg@tv-sign.ru>
To: Miklos Szeredi <mszeredi@suse.cz>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
William Lee Irwin III <wli@holomorphy.com>,
Nick Piggin <nickpiggin@yahoo.com.au>,
Ingo Molnar <mingo@elte.hu>,
linux-kernel@vger.kernel.org, stable@kernel.org,
Matt Helsley <matthltc@us.ibm.com>
Subject: Re: [PATCH] sys_remap_file_pages: fix ->vm_file accounting
Date: Wed, 30 Jan 2008 20:26:46 +0300 [thread overview]
Message-ID: <20080130172646.GA2355@tv-sign.ru> (raw)
In-Reply-To: <1201712101.31222.22.camel@tucsk.pomaz.szeredi.hu>
On 01/30, Miklos Szeredi wrote:
>
> On Wed, 2008-01-30 at 17:20 +0300, Oleg Nesterov wrote:
> > Fix ->vm_file accounting, mmap_region() may do do_munmap().
>
> There's a small problem with the patch: the vma itself is freed at
> unmap, so the fput(vma->vm_file) may crash. Here's an updated patch.
Ah, indeed, thanks!
Offtopic. I noticed this problem while looking at this patch:
http://marc.info/?l=linux-mm-commits&m=120141116911711
So this (the old vma could be removed before we create the new mapping)
means that the patch above has another problem: if we are remapping the
whole VM_EXECUTABLE vma, removed_exe_file_vma() can clear ->exe_file
while it shouldn't (Matt Helsley cc'ed).
Oleg.
next prev parent reply other threads:[~2008-01-30 17:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-30 14:20 [PATCH] sys_remap_file_pages: fix ->vm_file accounting Oleg Nesterov
2008-01-30 16:55 ` Miklos Szeredi
2008-01-30 17:26 ` Oleg Nesterov [this message]
2008-02-02 20:52 ` Matt Helsley
2008-02-02 21:17 ` Matt Helsley
2008-02-03 18:21 ` Oleg Nesterov
2008-02-06 20:33 ` Hugh Dickins
2008-02-07 0:16 ` Matt Helsley
2008-02-07 16:40 ` Hugh Dickins
2008-02-03 18:29 ` Oleg Nesterov
2008-02-06 20:13 ` Hugh Dickins
2008-02-11 10:15 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080130172646.GA2355@tv-sign.ru \
--to=oleg@tv-sign.ru \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthltc@us.ibm.com \
--cc=mingo@elte.hu \
--cc=mszeredi@suse.cz \
--cc=nickpiggin@yahoo.com.au \
--cc=stable@kernel.org \
--cc=wli@holomorphy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox