Re: ndiswrapper and GPL-only symbols redux

Andi Kleen
2008-01-30T03:28:43Z

Pavel Roskin <proski@gnu.org> writes:
>
> static inline void add_taint_module(struct module *mod, unsigned flag)
> {
> add_taint(flag);
> mod->taints |= flag;
> }
>
> The module taint is set before the symbols are resolved. Therefore, the
> GPL-only symbols won't be resolved.

I think using a separate taint flag that does not disable GPL symbols
for the ndiswrapper case would be a fair solution. After all the main
motivation for tainting ndiswrapper is to make it visible in oopses, but not
prevent it from loading in the first place.

How about you submit an incremental patch to do that?

-Andi