* arch/x86/kernel/test_nx.c compile error
@ 2008-01-30 18:25 Adrian Bunk
2008-01-30 18:42 ` Ingo Molnar
0 siblings, 1 reply; 7+ messages in thread
From: Adrian Bunk @ 2008-01-30 18:25 UTC (permalink / raw)
To: Arjan van de Ven, Ingo Molnar, Thomas Gleixner, hpa; +Cc: linux-kernel
<-- snip -->
...
CC [M] arch/x86/kernel/test_nx.o
{standard input}: Assembler messages:
{standard input}:58: Error: cannot represent relocation type BFD_RELOC_64
{standard input}:59: Error: cannot represent relocation type BFD_RELOC_64
make[2]: *** [arch/x86/kernel/test_nx.o] Error 1
make[1]: *** [arch/x86/kernel] Error 2
make: *** [sub-make] Error 2
$ gcc --version
gcc (GCC) 4.2.3 20080114 (prerelease) (Debian 4.2.2-7)
...
$ as --version
GNU assembler (GNU Binutils for Debian) 2.18.0.20080103
...
<-- snip -->
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: arch/x86/kernel/test_nx.c compile error
2008-01-30 18:25 arch/x86/kernel/test_nx.c compile error Adrian Bunk
@ 2008-01-30 18:42 ` Ingo Molnar
2008-01-30 18:44 ` Ingo Molnar
0 siblings, 1 reply; 7+ messages in thread
From: Ingo Molnar @ 2008-01-30 18:42 UTC (permalink / raw)
To: Adrian Bunk; +Cc: Arjan van de Ven, Thomas Gleixner, hpa, linux-kernel
* Adrian Bunk <bunk@kernel.org> wrote:
> ...
> CC [M] arch/x86/kernel/test_nx.o
> {standard input}: Assembler messages:
> {standard input}:58: Error: cannot represent relocation type BFD_RELOC_64
> {standard input}:59: Error: cannot represent relocation type BFD_RELOC_64
> make[2]: *** [arch/x86/kernel/test_nx.o] Error 1
> make[1]: *** [arch/x86/kernel] Error 2
> make: *** [sub-make] Error 2
does the patch below help?
Ingo
-------------->
Subject: x86: fix arch/x86/kernel/test_nx.c modular build bug
From: Ingo Molnar <mingo@elte.hu>
fix this modular build bug:
> CC [M] arch/x86/kernel/test_nx.o
> {standard input}: Assembler messages:
> {standard input}:58: Error: cannot represent relocation type BFD_RELOC_64
> {standard input}:59: Error: cannot represent relocation type BFD_RELOC_64
> make[2]: *** [arch/x86/kernel/test_nx.o] Error 1
> make[1]: *** [arch/x86/kernel] Error 2
Reported-by: Adrian Bunk <bunk@kernel.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
arch/x86/kernel/test_nx.c | 5 +++++
1 file changed, 5 insertions(+)
Index: linux-x86.q/arch/x86/kernel/test_nx.c
===================================================================
--- linux-x86.q.orig/arch/x86/kernel/test_nx.c
+++ linux-x86.q/arch/x86/kernel/test_nx.c
@@ -91,8 +91,13 @@ static noinline int test_address(void *a
".previous\n"
".section __ex_table,\"a\"\n"
" .align 8\n"
+#ifdef CONFIG_X86_32
+ " .long 0b\n"
+ " .long 2b\n"
+#endif
" .quad 0b\n"
" .quad 2b\n"
+#else
".previous\n"
: [rslt] "=r" (result)
: [fake_code] "r" (address), [zero] "r" (0UL), "0" (result)
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: arch/x86/kernel/test_nx.c compile error
2008-01-30 18:42 ` Ingo Molnar
@ 2008-01-30 18:44 ` Ingo Molnar
2008-01-30 18:59 ` Ingo Molnar
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Ingo Molnar @ 2008-01-30 18:44 UTC (permalink / raw)
To: Adrian Bunk; +Cc: Arjan van de Ven, Thomas Gleixner, hpa, linux-kernel
* Ingo Molnar <mingo@elte.hu> wrote:
> does the patch below help?
uhm, the one below instead.
Ingo
------------>
Subject: x86: fix arch/x86/kernel/test_nx.c modular build bug
From: Ingo Molnar <mingo@elte.hu>
fix this modular build bug:
> CC [M] arch/x86/kernel/test_nx.o
> {standard input}: Assembler messages:
> {standard input}:58: Error: cannot represent relocation type BFD_RELOC_64
> {standard input}:59: Error: cannot represent relocation type BFD_RELOC_64
> make[2]: *** [arch/x86/kernel/test_nx.o] Error 1
> make[1]: *** [arch/x86/kernel] Error 2
Reported-by: Adrian Bunk <bunk@kernel.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
arch/x86/kernel/test_nx.c | 5 +++++
1 file changed, 5 insertions(+)
Index: linux-x86.q/arch/x86/kernel/test_nx.c
===================================================================
--- linux-x86.q.orig/arch/x86/kernel/test_nx.c
+++ linux-x86.q/arch/x86/kernel/test_nx.c
@@ -91,8 +91,13 @@ static noinline int test_address(void *a
".previous\n"
".section __ex_table,\"a\"\n"
" .align 8\n"
+#ifdef CONFIG_X86_32
+ " .long 0b\n"
+ " .long 2b\n"
+#endif
" .quad 0b\n"
" .quad 2b\n"
+#else
".previous\n"
: [rslt] "=r" (result)
: [fake_code] "r" (address), [zero] "r" (0UL), "0" (result)
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: arch/x86/kernel/test_nx.c compile error
2008-01-30 18:44 ` Ingo Molnar
@ 2008-01-30 18:59 ` Ingo Molnar
2008-01-30 19:00 ` Adrian Bunk
2008-01-30 19:06 ` H. Peter Anvin
2 siblings, 0 replies; 7+ messages in thread
From: Ingo Molnar @ 2008-01-30 18:59 UTC (permalink / raw)
To: Adrian Bunk; +Cc: Arjan van de Ven, Thomas Gleixner, hpa, linux-kernel
* Ingo Molnar <mingo@elte.hu> wrote:
> > does the patch below help?
>
> uhm, the one below instead.
or this ...
Ingo
------------->
Subject: x86: fix arch/x86/kernel/test_nx.c modular build bug
From: Ingo Molnar <mingo@elte.hu>
fix this modular build bug:
> CC [M] arch/x86/kernel/test_nx.o
> {standard input}: Assembler messages:
> {standard input}:58: Error: cannot represent relocation type BFD_RELOC_64
> {standard input}:59: Error: cannot represent relocation type BFD_RELOC_64
> make[2]: *** [arch/x86/kernel/test_nx.o] Error 1
> make[1]: *** [arch/x86/kernel] Error 2
Reported-by: Adrian Bunk <bunk@kernel.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
arch/x86/kernel/test_nx.c | 5 +++++
1 file changed, 5 insertions(+)
Index: linux-x86.q/arch/x86/kernel/test_nx.c
===================================================================
--- linux-x86.q.orig/arch/x86/kernel/test_nx.c
+++ linux-x86.q/arch/x86/kernel/test_nx.c
@@ -91,8 +91,13 @@ static noinline int test_address(void *a
".previous\n"
".section __ex_table,\"a\"\n"
" .align 8\n"
+#ifdef CONFIG_X86_32
+ " .long 0b\n"
+ " .long 2b\n"
+#else
" .quad 0b\n"
" .quad 2b\n"
+#endif
".previous\n"
: [rslt] "=r" (result)
: [fake_code] "r" (address), [zero] "r" (0UL), "0" (result)
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: arch/x86/kernel/test_nx.c compile error
2008-01-30 18:44 ` Ingo Molnar
2008-01-30 18:59 ` Ingo Molnar
@ 2008-01-30 19:00 ` Adrian Bunk
2008-01-30 19:08 ` Ingo Molnar
2008-01-30 19:06 ` H. Peter Anvin
2 siblings, 1 reply; 7+ messages in thread
From: Adrian Bunk @ 2008-01-30 19:00 UTC (permalink / raw)
To: Ingo Molnar; +Cc: Arjan van de Ven, Thomas Gleixner, hpa, linux-kernel
On Wed, Jan 30, 2008 at 07:44:32PM +0100, Ingo Molnar wrote:
>
> * Ingo Molnar <mingo@elte.hu> wrote:
>
> > does the patch below help?
>
> uhm, the one below instead.
>
> Ingo
>
> ------------>
> Subject: x86: fix arch/x86/kernel/test_nx.c modular build bug
> From: Ingo Molnar <mingo@elte.hu>
>
> fix this modular build bug:
>
> > CC [M] arch/x86/kernel/test_nx.o
> > {standard input}: Assembler messages:
> > {standard input}:58: Error: cannot represent relocation type BFD_RELOC_64
> > {standard input}:59: Error: cannot represent relocation type BFD_RELOC_64
> > make[2]: *** [arch/x86/kernel/test_nx.o] Error 1
> > make[1]: *** [arch/x86/kernel] Error 2
>
> Reported-by: Adrian Bunk <bunk@kernel.org>
> Signed-off-by: Ingo Molnar <mingo@elte.hu>
> ---
> arch/x86/kernel/test_nx.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> Index: linux-x86.q/arch/x86/kernel/test_nx.c
> ===================================================================
> --- linux-x86.q.orig/arch/x86/kernel/test_nx.c
> +++ linux-x86.q/arch/x86/kernel/test_nx.c
> @@ -91,8 +91,13 @@ static noinline int test_address(void *a
> ".previous\n"
> ".section __ex_table,\"a\"\n"
> " .align 8\n"
> +#ifdef CONFIG_X86_32
> + " .long 0b\n"
> + " .long 2b\n"
> +#endif
> " .quad 0b\n"
> " .quad 2b\n"
> +#else
>...
You don't test whether your patches compile? ;-)
After the obvious fix it compiled.
Why wasn't this issue found before it entered Linus' tree?
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: arch/x86/kernel/test_nx.c compile error
2008-01-30 19:00 ` Adrian Bunk
@ 2008-01-30 19:08 ` Ingo Molnar
0 siblings, 0 replies; 7+ messages in thread
From: Ingo Molnar @ 2008-01-30 19:08 UTC (permalink / raw)
To: Adrian Bunk; +Cc: Arjan van de Ven, Thomas Gleixner, hpa, linux-kernel
* Adrian Bunk <bunk@kernel.org> wrote:
> > +#ifdef CONFIG_X86_32
> > + " .long 0b\n"
> > + " .long 2b\n"
> > +#endif
> > " .quad 0b\n"
> > " .quad 2b\n"
> > +#else
> >...
>
> You don't test whether your patches compile? ;-)
i did - but i didnt test whether i sent you the right, fixed one :-)
> After the obvious fix it compiled.
>
> Why wasn't this issue found before it entered Linus' tree?
because it was a relatively late patch and TEST_NX is dependent on a
modular build - which i dont test that often. I found and fixed a mirror
image bug in test_rodata.c.
Ingo
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: arch/x86/kernel/test_nx.c compile error
2008-01-30 18:44 ` Ingo Molnar
2008-01-30 18:59 ` Ingo Molnar
2008-01-30 19:00 ` Adrian Bunk
@ 2008-01-30 19:06 ` H. Peter Anvin
2 siblings, 0 replies; 7+ messages in thread
From: H. Peter Anvin @ 2008-01-30 19:06 UTC (permalink / raw)
To: Ingo Molnar; +Cc: Adrian Bunk, Arjan van de Ven, Thomas Gleixner, linux-kernel
Ingo Molnar wrote:
>
> Index: linux-x86.q/arch/x86/kernel/test_nx.c
> ===================================================================
> --- linux-x86.q.orig/arch/x86/kernel/test_nx.c
> +++ linux-x86.q/arch/x86/kernel/test_nx.c
> @@ -91,8 +91,13 @@ static noinline int test_address(void *a
> ".previous\n"
> ".section __ex_table,\"a\"\n"
> " .align 8\n"
> +#ifdef CONFIG_X86_32
> + " .long 0b\n"
> + " .long 2b\n"
> +#endif
> " .quad 0b\n"
> " .quad 2b\n"
> +#else
> ".previous\n"
> : [rslt] "=r" (result)
> : [fake_code] "r" (address), [zero] "r" (0UL), "0" (result)
#include <asm/asm>
...
_ASM_PTR "0b\n"
_ASM_PTR "2b\n"
...
... then you don't need any #ifdef at all..
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2008-01-30 19:09 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-01-30 18:25 arch/x86/kernel/test_nx.c compile error Adrian Bunk
2008-01-30 18:42 ` Ingo Molnar
2008-01-30 18:44 ` Ingo Molnar
2008-01-30 18:59 ` Ingo Molnar
2008-01-30 19:00 ` Adrian Bunk
2008-01-30 19:08 ` Ingo Molnar
2008-01-30 19:06 ` H. Peter Anvin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox