From: Andi Kleen <ak@suse.de>
To: Yinghai Lu <Yinghai.Lu@sun.com>
Cc: Ingo Molnar <mingo@elte.hu>, Christoph Lameter <clameter@sgi.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: PATCH] x86_64: make bootmap_start page align v4
Date: Wed, 30 Jan 2008 20:08:32 +0100 [thread overview]
Message-ID: <200801302008.32811.ak@suse.de> (raw)
In-Reply-To: <200801301051.08485.yinghai.lu@sun.com>
> + /*
> + * when you have 64g or 128g ram, bootmap will be pushed after bss
> + * section, the bootmap we get from early_node_mem via find_e820_area
> + * is not page aligned, we need to round it up to make sure bootmap
> + * is not overlapped with bss section
> + */
> + bootmap_start = round_up(bootmap_start, PAGE_SIZE);
The better solution would be to PAGE_ALIGN() the addresses
in bad_addr(). Or better fix it that no such alignment is needed to not
get conflicts.
-Andi
next prev parent reply other threads:[~2008-01-30 19:08 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200801291113.35974.yinghai.lu@sun.com>
2008-01-29 19:14 ` [PATCH 2/4] x86_64: make early_node_mem return align address v2 Yinghai Lu
2008-01-30 2:39 ` Yinghai Lu
2008-01-30 3:28 ` [PATCH 2/2] x86_64: make bootmap_start page align v3 Yinghai Lu
2008-01-30 18:51 ` PATCH] x86_64: make bootmap_start page align v4 Yinghai Lu
2008-01-30 19:08 ` Andi Kleen [this message]
2008-01-30 20:15 ` Yinghai Lu
2008-01-30 23:23 ` [PATCH] x86_64: make bootmap_start page align v5 Yinghai Lu
2008-01-30 23:50 ` Yinghai Lu
2008-01-31 3:02 ` PATCH] x86_64: make bootmap_start page align v4 Andi Kleen
2008-01-31 3:29 ` Yinghai Lu
2008-01-31 13:07 ` Ingo Molnar
2008-01-29 19:15 ` [PATCH 3/4] x86_64: Use early reservation for early node data Yinghai Lu
2008-01-29 19:16 ` [PATCH 4/4] x86_64: increse MAX_EARLY_RES for NODE_DATA and bootmap Yinghai Lu
2008-01-30 2:57 ` Andi Kleen
2008-01-30 3:25 ` Yinghai Lu
2008-01-31 13:24 ` Ingo Molnar
2008-01-31 13:34 ` Andi Kleen
2008-01-31 20:37 ` [PATCH] x86_64: add debug name for early_res Yinghai Lu
2008-01-31 20:44 ` [PATCH] x86_64: make bootmap_start page align v6 Yinghai Lu
2008-01-31 21:05 ` Ingo Molnar
2008-01-31 21:30 ` Yinghai Lu
2008-01-31 22:55 ` [PATCH] x86_64: remove unneeded round_up Yinghai Lu
2008-01-31 22:53 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200801302008.32811.ak@suse.de \
--to=ak@suse.de \
--cc=Yinghai.Lu@sun.com \
--cc=akpm@linux-foundation.org \
--cc=clameter@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox