Re: [patch 1/6] mmu_notifier: Core code

Avi Kivity
2008-01-29T20:44:04Z

Christoph Lameter wrote:
> On Tue, 29 Jan 2008, Andrea Arcangeli wrote:
>
>
>>> + struct mmu_notifier_head mmu_notifier; /* MMU notifier list */
>>> };
>>>
>> Not sure why you prefer to waste ram when MMU_NOTIFIER=n, this is a
>> regression (a minor one though).
>>
>
> Andrew does not like #ifdefs and it makes it possible to verify calling
> conventions if !CONFIG_MMU_NOTIFIER.
>
>

You could define mmu_notifier_head as an empty struct in that case.

--
Do not meddle in the internals of kernels, for they are subtle and quick to panic.