Re: [PATCH 1/5] x86: change_page_attr_clear fix

Andi Kleen
2008-01-31T12:53:29Z

On Thursday 31 January 2008 13:38:45 Thomas Gleixner wrote:
> On Thu, 31 Jan 2008, Andi Kleen wrote:
>
> > On Thursday 31 January 2008 08:35:59 Huang, Ying wrote:
> > > This patch replaces __change_page_attr_set_clr() with
> > > change_page_attr_set_clr() in change_page_attr_clear() to flush the
> > > TLB/cache properly.
> >
> > Good catch :-) It actually only needs to flush TLBs not caches in this
> > case.
>
> That's one of the items on our optimizations todo list already. There
> are more low hanging fruits, but we need to make sure that the non
> optimized version is bullet proof first.

I actually ported it already forward from my old patchkit (together
with some other improvements). Will post later.

-Andi