From: Ingo Molnar <mingo@elte.hu>
To: Yinghai Lu <yhlu.kernel@gmail.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>
Subject: Re: about relocs.c on x86
Date: Thu, 31 Jan 2008 10:52:23 +0100 [thread overview]
Message-ID: <20080131095223.GA11867@elte.hu> (raw)
In-Reply-To: <86802c440801310007oe8693c7q177d41a87c27ca7@mail.gmail.com>
* Yinghai Lu <yhlu.kernel@gmail.com> wrote:
> why not rename relocs.c to relocs_32.c?
>
> it is only used for 32 bit, even it is host app.
during the big first phase of unification we generally kept file names
untouched if they were only present in one of the previous
architectures. I.e. pure 32-bit and pure 64-bit files were not renamed
to _32/_64.
Now that we've got lots of unified 32/64-bit files it might make sense
to rename the 'standalone' ones into _32/_64 if they share the same
directory with 32/64-bit source files - to reduce the confusion. And
given that for example arch/x86/boot/compressed/misc.c is unified while
arch/x86/boot/compressed/relocs.c is 32-bit only, i'd agree with your
observation. Feel free to send a rename patch for such cases.
Ingo
next prev parent reply other threads:[~2008-01-31 9:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-31 8:07 about relocs.c on x86 Yinghai Lu
2008-01-31 8:33 ` Chris Snook
2008-01-31 9:13 ` Yinghai Lu
2008-01-31 9:17 ` Chris Snook
2008-01-31 9:52 ` Ingo Molnar [this message]
2008-01-31 10:02 ` Harvey Harrison
2008-01-31 10:11 ` Ingo Molnar
2008-01-31 10:21 ` Harvey Harrison
2008-01-31 10:38 ` Sam Ravnborg
2008-01-31 10:44 ` Harvey Harrison
2008-01-31 12:04 ` Ingo Molnar
2008-01-31 17:47 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080131095223.GA11867@elte.hu \
--to=mingo@elte.hu \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=yhlu.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox