Re: PATCH] x86_64: fix comments in vmlinux_64.lds

Ingo Molnar
2008-01-31T12:35:29Z

* Yinghai Lu <Yinghai.Lu@Sun.COM> wrote:

> ENTRY(startup_64)
> SECTIONS
> {
> - /* Be careful parts of head_64.S assume startup_64 is at
> + /* Be careful parts of head_64.S assume startup_32 is at
> * address 0.
> */
> . = 0;

but this linker script rule is about startup_64, not about startup_32.

startup_32 does exist on 64-bit too (and is 32-bit code), but it's
linked to a different address that is not 0:

ffffffff806c23c0 r startup_32

startup_64 is at offset 0:

ffffffff80200000 T startup_64

So your patch looks wrong to me.

Ingo