* [PATCH 3/5] x86: early_ioremap_reset fix 2
@ 2008-01-31 7:36 Huang, Ying
2008-01-31 12:13 ` Ingo Molnar
2008-01-31 12:15 ` Ingo Molnar
0 siblings, 2 replies; 3+ messages in thread
From: Huang, Ying @ 2008-01-31 7:36 UTC (permalink / raw)
To: Ingo Molnar, H. Peter Anvin, Thomas Gleixner, Andi Kleen; +Cc: linux-kernel
This patch fixes a bug of early_ioremap_reset(), which had been fixed
before by "convert the boot time page table to the kernels native
format" patch. But that patch has been reverted now.
Signed-off-by: Huang Ying <ying.huang@intel.com>
---
arch/x86/mm/ioremap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/arch/x86/mm/ioremap.c
+++ b/arch/x86/mm/ioremap.c
@@ -350,7 +350,7 @@ void __init early_ioremap_reset(void)
for (idx = FIX_BTMAP_BEGIN; idx >= FIX_BTMAP_END; idx--) {
addr = fix_to_virt(idx);
pte = early_ioremap_pte(addr);
- if (!*pte & _PAGE_PRESENT) {
+ if (*pte & _PAGE_PRESENT) {
phys = *pte & PAGE_MASK;
set_fixmap(idx, phys);
}
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 3/5] x86: early_ioremap_reset fix 2
2008-01-31 7:36 [PATCH 3/5] x86: early_ioremap_reset fix 2 Huang, Ying
@ 2008-01-31 12:13 ` Ingo Molnar
2008-01-31 12:15 ` Ingo Molnar
1 sibling, 0 replies; 3+ messages in thread
From: Ingo Molnar @ 2008-01-31 12:13 UTC (permalink / raw)
To: Huang, Ying
Cc: Ingo Molnar, H. Peter Anvin, Thomas Gleixner, Andi Kleen,
linux-kernel
* Huang, Ying <ying.huang@intel.com> wrote:
> This patch fixes a bug of early_ioremap_reset(), which had been fixed
> before by "convert the boot time page table to the kernels native
> format" patch. But that patch has been reverted now.
thanks, applied. (The native-pagetables patch is in x86.git too again,
but i'll add your patch first - just in case it needs to be reverted
again due to some test failure.)
Ingo
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 3/5] x86: early_ioremap_reset fix 2
2008-01-31 7:36 [PATCH 3/5] x86: early_ioremap_reset fix 2 Huang, Ying
2008-01-31 12:13 ` Ingo Molnar
@ 2008-01-31 12:15 ` Ingo Molnar
1 sibling, 0 replies; 3+ messages in thread
From: Ingo Molnar @ 2008-01-31 12:15 UTC (permalink / raw)
To: Huang, Ying
Cc: Ingo Molnar, H. Peter Anvin, Thomas Gleixner, Andi Kleen,
linux-kernel
* Huang, Ying <ying.huang@intel.com> wrote:
> - if (!*pte & _PAGE_PRESENT) {
> + if (*pte & _PAGE_PRESENT) {
btw., the usual form for that is pte_present(*pte). (i've fixed this up
in the patch)
Ingo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-01-31 12:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-01-31 7:36 [PATCH 3/5] x86: early_ioremap_reset fix 2 Huang, Ying
2008-01-31 12:13 ` Ingo Molnar
2008-01-31 12:15 ` Ingo Molnar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox