public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: "Huang, Ying" <ying.huang@intel.com>
Cc: Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
	Thomas Gleixner <tglx@linutronix.de>, Andi Kleen <ak@suse.de>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/5] x86: early_ioremap_reset fix 2
Date: Thu, 31 Jan 2008 13:15:05 +0100	[thread overview]
Message-ID: <20080131121505.GE12571@elte.hu> (raw)
In-Reply-To: <1201764964.12950.24.camel@caritas-dev.intel.com>


* Huang, Ying <ying.huang@intel.com> wrote:

> -		if (!*pte & _PAGE_PRESENT) {
> +		if (*pte & _PAGE_PRESENT) {

btw., the usual form for that is pte_present(*pte). (i've fixed this up 
in the patch)

	Ingo

      parent reply	other threads:[~2008-01-31 12:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-31  7:36 [PATCH 3/5] x86: early_ioremap_reset fix 2 Huang, Ying
2008-01-31 12:13 ` Ingo Molnar
2008-01-31 12:15 ` Ingo Molnar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080131121505.GE12571@elte.hu \
    --to=mingo@elte.hu \
    --cc=ak@suse.de \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=ying.huang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox