From: Ingo Molnar <mingo@elte.hu>
To: "Huang, Ying" <ying.huang@intel.com>
Cc: Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>, Andi Kleen <ak@suse.de>,
linux-kernel@vger.kernel.org,
Arjan van de Ven <arjan@infradead.org>
Subject: Re: [PATCH 5/5] x86: EFI memory mapping changes according to changes to ioremap and c_p_a
Date: Thu, 31 Jan 2008 13:18:23 +0100 [thread overview]
Message-ID: <20080131121823.GF12571@elte.hu> (raw)
In-Reply-To: <1201764968.12950.26.camel@caritas-dev.intel.com>
* Huang, Ying <ying.huang@intel.com> wrote:
> + /* Assume pages are mapped as WB */
> + if (mode == IOR_MODE_UNCACHED)
> + set_memory_uc(md->virt_addr, md->num_pages);
> + /* Assume pages are mapped as unexecutable */
> + if ((__supported_pte_mask & _PAGE_NX) &&
> + xmode == IOR_XMODE_EXEC)
> + set_memory_x(md->virt_addr, md->num_pages);
hm, why is the check for __supported_pte_mask needed? That is already
listened to in set_memory_x(). [if not then it's an ioremap bug that we
want to fix.]
> -static int ioremap_change_attr(unsigned long paddr, unsigned long size,
> - enum ioremap_mode mode,
> - enum ioremap_xmode xmode)
> +int ioremap_change_attr(unsigned long paddr, unsigned long size,
> + enum ioremap_mode mode,
> + enum ioremap_xmode xmode)
hm, there should be no need to use this raw API.
Ingo
next prev parent reply other threads:[~2008-01-31 12:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-31 7:36 [PATCH 5/5] x86: EFI memory mapping changes according to changes to ioremap and c_p_a Huang, Ying
2008-01-31 12:18 ` Ingo Molnar [this message]
2008-01-31 13:30 ` huang ying
2008-01-31 14:36 ` Arjan van de Ven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080131121823.GF12571@elte.hu \
--to=mingo@elte.hu \
--cc=ak@suse.de \
--cc=arjan@infradead.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox