Re: x86 arch updates also broke s390

Nick Piggin
2008-01-31T12:37:54Z

On Thu, Jan 31, 2008 at 11:24:54AM +0100, Ingo Molnar wrote:
>
> * Martin Schwidefsky <schwidefsky@de.ibm.com> wrote:
>
> > On Thu, 2008-01-31 at 02:33 +0200, Adrian Bunk wrote:
> > > <-- snip -->
> > >
> > > ...
> > > CC arch/s390/kernel/asm-offsets.s
> > > In file included from
> > > /home/bunk/linux/kernel-2.6/git/linux-2.6/arch/s390/kernel/asm-offsets.c:7:
> > > /home/bunk/linux/kernel-2.6/git/linux-2.6/include/linux/sched.h: In
> > > function 'spin_needbreak':
> > > /home/bunk/linux/kernel-2.6/git/linux-2.6/include/linux/sched.h:1931:
> > > error: implicit declaration of function '__raw_spin_is_contended'
> > > make[2]: *** [arch/s390/kernel/asm-offsets.s] Error 1
> > >
> > > <-- snip -->
> >
> > Defining GENERIC_LOCKBREAK in arch/s390/Kconfig takes care of it. I'll
> > cook up a patch and queue it in git390.
>
> thanks!

Yeah thanks, don't know what happened with this, sorry. I thought I
had defined it for all SMP capable ones, so maybe it was a quilt
error or something on my part.